commit d2818a61 leads vim response very slowly on Windows

[roachsinai]

GVim sometimes response after more than one seconds, and the key I pressed can show on rightbottom on Gvim like below:

Releated commit is d2818a6

Revert to d2818a6^, above problem disappear.

---

Platform: Win11, vim 64-bit.

[tpope]

Can you narrow down the cause? If you comment out the rename, does the problem go away?

[roachsinai]

Yes, comment out the rename at line 85, the problem go away.

[tpope]

Maybe it's getting hung up overwriting the existing file? Maybe try adding a delete(g:this_obsession) before it? (Although that kind of defeats the purpose of the change.)

[roachsinai]

Just wanna make sure that when overwrite the existing file, does it was opened? In windows you can't move/delete an opened file.

[tpope]

The file in g:this_obsession shouldn't be open at that point, no.