bug: environment messed up

[franciscocpg]

Giving the following serverless configuration

function1:
  handler: file1.handler
  environmentSecrets:
      ENV1: '/my-project/${opt:stage}/ENV1'

function2:
  handler: file2.handler
  environmentSecrets:
      ENV2: '/my-project/${opt:stage}/ENV2'

When invoking function1 the environment is injected with ENV2 variable instead of ENV1. And that's because of the the code below:

serverless-secrets/plugin/index.js

Lines 240 to 247 in 948e5db

	const environments = Object.keys(functions)
	.reduce((environments, key) => {
	const functionName = functions[key].handler.split('.')[1]
	if (functions[key].environmentSecrets) {
	environments[functionName] = functions[key].environmentSecrets
	}
	return environments
	}, {})

I've done a fix for me (franciscocpg@1914052) and it worked the way I've expected but before proposing a PR I'd like to know the rationale behind this split.

Maybe there is something I'm not seeing.

[sneha-nagole]

Thank you for the plugin.

When all functions have same handler is another case where environment is messed up. Below is the sample config.

function1:
handler: file.handler
environment:
ENV1: 'fn1 env1 value'
environmentSecrets:
ENVSECRET1: '/my-project/${opt:stage}/ENVSECRET1'

function2:
handler: file.handler
environment:
ENV1: 'fn2 env1 value'
environmentSecrets:
ENVSECRET1: '/my-project/${opt:stage}/ENVSECRET2'

If we can generate environments object by function name instead, it would be a more generic fix.

[sneha-nagole]

Prepared PR to fix this issue - #38.