Merge pull request #62 from trocco-io/fix_empty_field_as_null

mzumi · web-flow · commit 41e976a6ba42 · 2023-07-12T17:44:43.000+09:00
Fix COPY INTO syntax
diff --git a/src/main/java/org/embulk/output/snowflake/SnowflakeOutputConnection.java b/src/main/java/org/embulk/output/snowflake/SnowflakeOutputConnection.java
@@ -182,11 +182,11 @@ protected String buildCopySQL(
     quoteInternalStoragePath(sb, stageIdentifier, snowflakeStageFileName);
     sb.append(" FILE_FORMAT = ( TYPE = CSV FIELD_DELIMITER = '");
     sb.append(delimiterString);
-    sb.append("') ");
+    sb.append("'");
     if (!emptyFieldAsNull) {
-      sb.append("EMPTY_FIELD_AS_NULL = FALSE");
+      sb.append(" EMPTY_FIELD_AS_NULL = FALSE");
     }
-    sb.append(";");
+    sb.append(" );");
     return sb.toString();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -182,11 +182,11 @@ protected String buildCopySQL(`
`182`	`182`	`quoteInternalStoragePath(sb, stageIdentifier, snowflakeStageFileName);`
`183`	`183`	`sb.append(" FILE_FORMAT = ( TYPE = CSV FIELD_DELIMITER = '");`
`184`	`184`	`sb.append(delimiterString);`
`185`		`- sb.append("') ");`
	`185`	`+ sb.append("'");`
`186`	`186`	`if (!emptyFieldAsNull) {`
`187`		`- sb.append("EMPTY_FIELD_AS_NULL = FALSE");`
	`187`	`+ sb.append(" EMPTY_FIELD_AS_NULL = FALSE");`
`188`	`188`	`}`
`189`		`- sb.append(";");`
	`189`	`+ sb.append(" );");`
`190`	`190`	`return sb.toString();`
`191`	`191`	`}`
`192`	`192`