Wrap names with double quotes

mzumi · mzumi · commit c234f9bc65ab · 2024-06-14T09:33:02.000Z
diff --git a/src/main/java/org/embulk/output/SnowflakeOutputPlugin.java b/src/main/java/org/embulk/output/SnowflakeOutputPlugin.java
@@ -167,8 +167,7 @@ protected JdbcOutputConnector getConnector(PluginTask task, boolean retryableMet
         throw new ConfigException(e);
       }
     }
-
-    props.setProperty("warehouse", t.getWarehouse());
+    props.setProperty("warehouse", "\"" + escapeDoubleQuote(t.getWarehouse()) + "\"");
     props.setProperty("db", t.getDatabase());
     props.setProperty("schema", t.getSchema());
     if (!t.getRole().isEmpty()) {
@@ -368,4 +367,8 @@ public void timestampColumn(Column column) {
     }
     return new JdbcSchema(Collections.unmodifiableList(columns));
   }
+
+  private String escapeDoubleQuote(String s) {
+    return s.replaceAll("\"", "\"\"");
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,7 @@ protected JdbcOutputConnector getConnector(PluginTask task, boolean retryableMet`
`167`	`167`	`throw new ConfigException(e);`
`168`	`168`	`}`
`169`	`169`	`}`
`170`		`-`
`171`		`- props.setProperty("warehouse", t.getWarehouse());`
	`170`	`+ props.setProperty("warehouse", "\"" + escapeDoubleQuote(t.getWarehouse()) + "\"");`
`172`	`171`	`props.setProperty("db", t.getDatabase());`
`173`	`172`	`props.setProperty("schema", t.getSchema());`
`174`	`173`	`if (!t.getRole().isEmpty()) {`
`@@ -368,4 +367,8 @@ public void timestampColumn(Column column) {`
`368`	`367`	`}`
`369`	`368`	`return new JdbcSchema(Collections.unmodifiableList(columns));`
`370`	`369`	`}`
	`370`	`+`
	`371`	`+ private String escapeDoubleQuote(String s) {`
	`372`	`+ return s.replaceAll("\"", "\"\"");`
	`373`	`+ }`
`371`	`374`	`}`