Issue with Go to Previous/Next Position not working in certain navigation scenarios

[amirsol81]

The "Go to previous/next position" feature is really great, and I truly appreciate that you've added it. However, it seems to have some limitations at the moment:

1. If we use the Table of Contents and jump to a chapter, "Go to previous position" doesn't work. I think it should work there too. For example, open a book, press Control+T, select a chapter, and then try to go back with ALT+Left. Paperback says "No previous position."

2. Similarly, if we use the Left Bracket and Right Bracket keys to jump between sections, P or SHIFT+P to move by page, or if we use N and B to jump to previous/next notes or bookmarks, "Go to previous/next position" doesn't work.

3. This also applies to navigating with H between headings. So, if we’re in the middle of a paragraph and press H to go to the next heading, ALT+Left doesn’t bring us back to the previous position in the middle of the paragraph.

Is it possible to make this feature work for all or at least some of these scenarios?

[trypsynth]

I'd be behind making it work for at least some of them, e.g. the toc, but headings for example I think are entirely worthless.
The purpose of this feature in my mind is to let you get back to where you were previously because you jumped very far (e.g. because of a link, epub section, etc). I'm personally in favor of making it work for a few other situations, but not headings for example, because if I press enter on a link, go by heading a few times, then want to go back to where the link was, I'll have to spam alt+left arrow, assuming that hasn't been taken out of the navigation history already anyways.

[amirsol81]

@trypsynth Agreed. Fixing it for, say, toc would be a good idea. Of course, as you implement the Elements list and one selects a far-off heading from that dialog, returning to the previous position would sound logical. There's a difference between using H and SHIFT+H to navigate around headings, and using the Elements list to jump to a far-off heading.

[trypsynth]

I think a good set of rules is as follows:

• If the movement was done through any sort of dialog (e.g. go to line/percent/page, table of contents, etc.), add it to the navigation history. Sure, you could just enter one line or page number higher, but you could also go by 1000.
• Pressing enter on an internal link that successfully navigates you somewhere else in the document should add to the navigation history.
• No go to previous/next element commands should add to the navigation history on their own (possibly with epub sections being an exception, I could go either way on those. On the one hand I see the argument for them being similar to navigating by heading, but some epubs have really far apart sections. Open to feedback on that one).

Thoughts?

[amirsol81]

@trypsynth Fantastic! The rules are perfect. I also think the navigation should work for Epub sections as you mentioned.