"Favorite" animation on the home timeline is timed poorly

[Sirs0ri]

Detailed description

When tapping the star icon on my home timeline, the "unstarred" version of the icon flashes for a very short moment after the "pop" animation, before changing to its active state. In all other places (detail view, local/federated timelines, profiles), the icon transitions smoothly during the "pop" animation.

Clip of the broken animation (you should be able to reduce the playback speed after right-clicking the video):

fav-broken.mp4

Clip of the correct animation, in the detail view of a post:

fav-correct.mp4

Steps to reproduce the problem

1. Open your home ("following") timeline
2. Star a post

Debug information

Tusky Test 28.0-d35dcecf

Device:

samsung SM-G970F
Android-Version: 12
SDK-Version: 31

Account:

@Sirs0ri@corteximplant.com
Version: 4.4.0-alpha.4+glitch.cortex

[connyduck]

Wow thanks for noticing 🤯
That is definitely a regression from #5084, looking into it