Remove Factory type alias, simplify version-dependent Buildable

Author: lrytz

src/main/scala-2.13+/org/scalacheck/ScalaVersionSpecific.scala

@@ -1,31 +1,18 @@
-package org.scalacheck
+/*-------------------------------------------------------------------------*\
+**  ScalaCheck                                                             **
+**  Copyright (c) 2007-2018 Rickard Nilsson. All rights reserved.          **
+**  http://www.scalacheck.org                                              **
+**                                                                         **
+**  This software is released under the terms of the Revised BSD License.  **
+**  There is NO WARRANTY. See the file LICENSE for the full text.          **
+\*------------------------------------------------------------------------ */
 
-import java.util.ArrayList
+package org.scalacheck
 
-import scala.collection.{BitSet, Factory}
-import scala.collection.mutable.Builder
 import rng.Seed
 
 private[scalacheck] object ScalaVersionSpecific {
   def toLazyList[T](i: IterableOnce[T]) = LazyList.from(i)
-
-  def listFactory[T]: Factory[T, List[T]] =
-    new Factory[T, List[T]] with Serializable {
-      def fromSpecific(source: IterableOnce[T]): List[T] = List.from(source)
-      def newBuilder: Builder[T, List[T]] = List.newBuilder[T]
-    }
-
-  def bitsetFactory[T]: Factory[Int, BitSet] =
-    new Factory[Int, BitSet] with Serializable {
-      def fromSpecific(source: IterableOnce[Int]) = BitSet.fromSpecific(source)
-      def newBuilder: Builder[Int, BitSet] = BitSet.newBuilder
-    }
-
-  def mapFactory[T, U]: Factory[(T, U), Map[T, U]] =
-    new Factory[(T, U), Map[T, U]] with Serializable {
-      def fromSpecific(source: IterableOnce[(T, U)]) = Map.from(source)
-      def newBuilder: Builder[(T, U), Map[T, U]] = Map.newBuilder[T, U]
-    }
 }
 
 private[scalacheck] trait GenVersionSpecific {
@@ -51,13 +38,3 @@ private[scalacheck] trait CogenVersionSpecific {
   implicit def cogenLazyList[A: Cogen]: Cogen[LazyList[A]] =
     Cogen.it(_.iterator)
 }
-
-private[scalacheck] class ArrayListBuilder[T] extends Builder[T, ArrayList[T]] {
-  private val al = new ArrayList[T]
-  def addOne(x: T): this.type = {
-    al.add(x)
-    this
-  }
-  def clear(): Unit = al.clear()
-  def result(): ArrayList[T] = al
-}

src/main/scala-2.13-/org/scalacheck/ScalaVersionSpecific.scala

@@ -1,39 +1,21 @@
-package org.scalacheck
+/*-------------------------------------------------------------------------*\
+**  ScalaCheck                                                             **
+**  Copyright (c) 2007-2018 Rickard Nilsson. All rights reserved.          **
+**  http://www.scalacheck.org                                              **
+**                                                                         **
+**  This software is released under the terms of the Revised BSD License.  **
+**  There is NO WARRANTY. See the file LICENSE for the full text.          **
+\*------------------------------------------------------------------------ */
 
-import java.util.ArrayList
+package org.scalacheck
 
-import scala.collection.generic.{CanBuildFrom, Sorted}
+import scala.collection.generic.Sorted
 import scala.collection.immutable.Stream
-import scala.collection.mutable.Builder
-import scala.collection.{BitSet, TraversableOnce}
+import scala.collection.TraversableOnce
 
 private[scalacheck] object ScalaVersionSpecific {
   def toLazyList[T](i: TraversableOnce[T]) = i.toStream
 
-  type Factory[-A, +C] = CanBuildFrom[Nothing, A, C]
-
-  def listFactory[T]: CanBuildFrom[List[T], T, List[T]] =
-    new CanBuildFrom[List[T], T, List[T]] with Serializable {
-      def apply(from: List[T]) = List.newBuilder[T]
-      def apply() = List.newBuilder[T]
-    }
-
-  def bitsetFactory[T]: CanBuildFrom[BitSet, Int, BitSet] =
-    new CanBuildFrom[BitSet, Int, BitSet] with Serializable {
-      def apply(from: BitSet) = BitSet.newBuilder
-      def apply() = BitSet.newBuilder
-    }
-
-  def mapFactory[T, U]: CanBuildFrom[Map[T, U], (T, U), Map[T, U]] =
-    new CanBuildFrom[Map[T, U], (T, U), Map[T, U]] with Serializable {
-      def apply(from: Map[T, U]) = Map.newBuilder[T, U]
-      def apply() = Map.newBuilder[T, U]
-    }
-
-  implicit class CBFExt[-A, +C](val cbf: CanBuildFrom[Nothing, A, C]) extends AnyVal {
-    def newBuilder: Builder[A, C] = cbf()
-  }
-
   type LazyList[+A] = Stream[A]
   val LazyList      = Stream
 
@@ -55,13 +37,3 @@ private[scalacheck] trait CogenVersionSpecific
 private[scalacheck] trait GenSpecificationVersionSpecific {
   def infiniteLazyList[T](g: => Gen[T]): Gen[Stream[T]] = Gen.infiniteStream(g)
 }
-
-private[scalacheck] class ArrayListBuilder[T] extends Builder[T, ArrayList[T]] {
-  private val al = new ArrayList[T]
-  def +=(x: T): this.type = {
-    al.add(x)
-    this
-  }
-  def clear(): Unit = al.clear()
-  def result(): ArrayList[T] = al
-}

src/main/scala/org/scalacheck/util/Buildable.scala

@@ -10,8 +10,6 @@
 package org.scalacheck.util
 
 import scala.collection.{mutable, Map => _, _}
-import org.scalacheck.{ScalaVersionSpecific, ArrayListBuilder}
-import ScalaVersionSpecific._
 
 trait Buildable[T,C] extends Serializable {
   def builder: mutable.Builder[T,C]
@@ -22,30 +20,13 @@ trait Buildable[T,C] extends Serializable {
   }
 }
 
-/**
-  * Factory instances implementing Serializable, so that the objects capturing those can be
-  * serializable too.
-  */
-// Names are `..CanBuildFrom` for binary compatibility. Change to `..Factory` in a major release.
-object SerializableCanBuildFroms {
-  implicit def listCanBuildFrom[T]: Factory[T, List[T]] = ScalaVersionSpecific.listFactory
-  implicit def bitsetCanBuildFrom[T]: Factory[Int, BitSet] = ScalaVersionSpecific.bitsetFactory
-  implicit def mapCanBuildFrom[T, U]: Factory[(T, U), Map[T, U]] = ScalaVersionSpecific.mapFactory
-}
-
-object Buildable {
-  // Name is `..CanBuildFrom` for binary compatibility. Change to `..Factory` in a major release.
-  implicit def buildableCanBuildFrom[T,C](implicit f: Factory[T,C]) =
-    new Buildable[T,C] {
-      def builder = f.newBuilder
-    }
-
+object Buildable extends BuildableVersionSpecific {
   import java.util.ArrayList
   implicit def buildableArrayList[T]: Buildable[T, ArrayList[T]] = new Buildable[T,ArrayList[T]] {
     def builder = new ArrayListBuilder[T]
   }
-
 }
+
 /*
 object Buildable2 {