chore: move CI to GitHub Actions and fix internal complaints (#1888)

* chore: move CI to GitHub Actions

* Switch prepare action to npm

* workflows/

* Test fill: mergeLintConfigurations

* ignore globAsync complaints

* npm run format:write

* More convertVSCodeConfig tests

* Remove branch requirement altogether

* More convertVSCodeConfig tests

Author: JoshuaKGoldberg

.circleci/config.yml

@@ -0,0 +1,13 @@
+description: Prepares the repo for a typical CI job
+
+name: Prepare
+
+runs:
+    steps:
+        - uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6
+          with:
+              cache: npm
+              node-version: 24.11.1
+        - run: npm ci
+          shell: bash
+    using: composite

.github/actions/prepare/action.yaml

@@ -0,0 +1,38 @@
+jobs:
+    compile:
+        name: Compile
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
+            - uses: ./.github/actions/prepare
+            - run: npm run compile
+            - run: node bin/tslint-to-eslint-config --version
+    format:
+        name: Format
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
+            - uses: ./.github/actions/prepare
+            - run: npm run prettier -- --list-different
+    lint:
+        name: Lint
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
+            - uses: ./.github/actions/prepare
+            - run: npm run eslint
+    test:
+        name: Test
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
+            - uses: ./.github/actions/prepare
+            - run: npm run test:ci
+
+name: CI
+
+on:
+    pull_request: ~
+    push:
+        branches:
+            - main

.github/workflows/ci.yaml

@@ -13,7 +13,6 @@ module.exports = {
     ],
     coverageThreshold: {
         global: {
-            branches: 100,
             functions: 100,
             lines: 100,
             statements: 100,

jest.config.cjs

@@ -2,9 +2,12 @@ import { glob } from "glob";
 
 export const globAsync = async (pattern: string) => {
     return new Promise<Error | string[]>((resolve) => {
+        /* eslint-disable */
+        // @ts-expect-error -- Will be removed in #1886.
         glob(pattern, (error, matches) => {
             resolve(error ?? matches);
         });
+        /* eslint-enable */
     });
 };
 

src/adapters/globAsync.ts

@@ -3,9 +3,8 @@ export type WithDependencies<Args extends any[] = any[], Return = any> = (
     ...args: Args
 ) => Return;
 
-export type SansDependencies<Method> = Method extends WithDependencies<infer Args, infer Return>
-    ? (...args: Args) => Return
-    : never;
+export type SansDependencies<Method> =
+    Method extends WithDependencies<infer Args, infer Return> ? (...args: Args) => Return : never;
 
 export const bind = <Dependencies = any, Args extends any[] = any[], Return = any>(
     method: WithDependencies<Args, Return>,

src/binding.ts

@@ -16,7 +16,7 @@ const createStubRunCliDependencies = (overrides: Partial<RunCliDependencies> = {
         ({
             data: createStubOriginalConfigurationsData(),
             status: ResultStatus.Succeeded,
-        } as const),
+        }) as const,
     ...overrides,
     logger: createStubLogger(),
 });

src/cli/runCli.test.ts

@@ -41,6 +41,94 @@ Object {
 `);
     });
 
+    it("does not include eslint.autoFixOnSave when editor.codeActionsOnSave is false", () => {
+        // Arrange
+        const editorSettings = {
+            "editor.codeActionsOnSave": false,
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toMatchInlineSnapshot(`
+Object {
+  "contents": "{
+    \\"editor.codeActionsOnSave\\": false,
+    \\"unrelated\\": true
+}",
+  "missing": Array [],
+}
+`);
+    });
+
+    it("does not include eslint.autoFixOnSave when editor.codeActionsOnSave is null", () => {
+        // Arrange
+        const editorSettings = {
+            "editor.codeActionsOnSave": null,
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toMatchInlineSnapshot(`
+Object {
+  "contents": "{
+    \\"editor.codeActionsOnSave\\": null,
+    \\"unrelated\\": true
+}",
+  "missing": Array [],
+}
+`);
+    });
+
+    it("does not include eslint.autoFixOnSave when editor.codeActionsOnSave is a number", () => {
+        // Arrange
+        const editorSettings = {
+            "editor.codeActionsOnSave": 1,
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toMatchInlineSnapshot(`
+Object {
+  "contents": "{
+    \\"editor.codeActionsOnSave\\": 1,
+    \\"unrelated\\": true
+}",
+  "missing": Array [],
+}
+`);
+    });
+
+    it("does not include eslint.autoFixOnSave when editor.codeActionsOnSave is an empty object", () => {
+        // Arrange
+        const editorSettings = {
+            "editor.codeActionsOnSave": {},
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toMatchInlineSnapshot(`
+Object {
+  "contents": "{
+    \\"editor.codeActionsOnSave\\": {},
+    \\"unrelated\\": true
+}",
+  "missing": Array [],
+}
+`);
+    });
+
     it("does not include eslint.autoFixOnSave when source.fixAll.tslint is false", () => {
         // Arrange
         const editorSettings = {
@@ -112,6 +200,23 @@ Object {
         });
     });
 
+    it("does not include configFile when tslint.configFile is a number", () => {
+        // Arrange
+        const editorSettings = {
+            "tslint.configFile": 1,
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toEqual({
+            contents: JSON.stringify(editorSettings, null, 4),
+            missing: [],
+        });
+    });
+
     it("includes configFile when tslint.configFile matches", () => {
         // Arrange
         const editorSettings = {
@@ -138,6 +243,28 @@ Object {
 `);
     });
 
+    it("does not include configFile when tslint.configFile does not match", () => {
+        // Arrange
+        const editorSettings = {
+            "tslint.configFile": "../other.json",
+            unrelated: true,
+        };
+
+        // Act
+        const result = convertVSCodeConfig(JSON.stringify(editorSettings, null, 4), stubSettings);
+
+        // Assert
+        expect(result).toMatchInlineSnapshot(`
+Object {
+  "contents": "{
+    \\"tslint.configFile\\": \\"../other.json\\",
+    \\"unrelated\\": true
+}",
+  "missing": Array [],
+}
+`);
+    });
+
     it("includes missing notices when known missing settings are included", () => {
         // Arrange
         const editorSettings = {

src/converters/editorConfigs/converters/convertVSCodeConfig.test.ts

@@ -3,7 +3,10 @@ import { EOL } from "os";
 import { ErrorSummary } from "./errorSummary";
 
 export class ConfigurationError implements ErrorSummary {
-    public constructor(private readonly error: Error, private readonly complaint: string) {}
+    public constructor(
+        private readonly error: Error,
+        private readonly complaint: string,
+    ) {}
 
     public getSummary(): string {
         return `${this.complaint}: ${this.error.stack}${EOL}`;