Added, corrected end-to-end tests for TypeScript config paths (#134)

Josh Goldberg · web-flow · commit 61f77c660ba6 · 2019-08-03T11:20:16.000-04:00
Tests were failing previously for not having the right `cwd` set in the executing command. Changed that in `runTests.ts` and voila!, they're all running correctly now! Hooray.
diff --git a/test/createTests.ts b/test/createTests.ts
@@ -23,13 +23,7 @@ export type TestSettings = {
 
 jest.setTimeout(10000);
 
-const act = async (testArgs: string[]) => {
-    try {
-        return await exec(`ts-node bin/tslint-to-eslint-config ${testArgs.join(" ")}`);
-    } catch (error) {
-        return error;
-    }
-};
+const binFile = path.join(__dirname, "../bin/tslint-to-eslint-config");
 
 export const createTests = (
     cwd: string,
@@ -40,6 +34,16 @@ export const createTests = (
     const cwdPath = (fileName: string) => path.join(cwd, fileName);
     const readTestFile = async (fileName: string) => (await readFile(cwdPath(fileName))).toString();
 
+    const act = async (testArgs: string[]) => {
+        try {
+            return await exec(`ts-node ${binFile} ${testArgs.join(" ")}`, {
+                cwd,
+            });
+        } catch (error) {
+            return error;
+        }
+    };
+
     describe(testName, () => {
         test("configuration output", async () => {
             // Arrange
diff --git a/test/tests/custom eslint path/eslintrc.js b/test/tests/custom eslint path/eslintrc.js
@@ -1,31 +1,74 @@
 module.exports = {
-    env: {
-        es6: true,
-        node: true,
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
     },
-    parser: "@typescript-eslint/parser",
-    parserOptions: {
-        project: "tsconfig.json",
-        sourceType: "module",
-    },
-    plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
-    rules: {
+    "extends": [],
+    "rules": {
         "@typescript-eslint/array-type": "error",
         "@typescript-eslint/interface-name-prefix": "error",
+        "@typescript-eslint/member-ordering": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-param-reassign": "off",
+        "@typescript-eslint/no-parameter-properties": "off",
+        "@typescript-eslint/no-use-before-declare": "off",
+        "@typescript-eslint/promise-function-async": "off",
+        "@typescript-eslint/unbound-method": "off",
+        "arrow-body-style": "off",
+        "default-case": "off",
+        "linebreak-style": "off",
+        "no-bitwise": "off",
+        "no-empty": "off",
+        "no-empty-functions": "off",
         "no-magic-numbers": "off",
         "prefer-template": "off",
         "@typescript-eslint/tslint/config": [
             "error",
             {
-                rules: {
-                    "no-implicit-dependencies": [true, "dev"],
+                "rules": {
+                    "no-implicit-dependencies": [
+                        true,
+                        "dev"
+                    ],
                     "strict-boolean-expressions": [
                         true,
                         "allow-boolean-or-undefined",
-                        "allow-number",
-                    ],
-                },
-            },
-        ],
+                        "allow-number"
+                    ]
+                }
+            }
+        ]
+    },
+    "globals": {},
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
     },
+    "plugins": [
+        "@typescript-eslint",
+        "@typescript-eslint/tslint"
+    ],
+    "settings": {
+        "import/resolver": {
+            "node": {
+                "extensions": [
+                    ".mjs",
+                    ".js",
+                    ".json"
+                ]
+            }
+        },
+        "import/extensions": [
+            ".js",
+            ".mjs",
+            ".jsx"
+        ],
+        "import/core-modules": [],
+        "import/ignore": [
+            "node_modules",
+            "\\.(coffee|scss|css|less|hbs|svg|json)$"
+        ]
+    }
 };
diff --git a/test/tests/custom eslint path/expected.json b/test/tests/custom eslint path/expected.json
@@ -1,31 +1,74 @@
 module.exports = {
-    env: {
-        es6: true,
-        node: true,
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
     },
-    parser: "@typescript-eslint/parser",
-    parserOptions: {
-        project: "tsconfig.json",
-        sourceType: "module",
-    },
-    plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
-    rules: {
+    "extends": [],
+    "rules": {
         "@typescript-eslint/array-type": "error",
         "@typescript-eslint/interface-name-prefix": "error",
+        "@typescript-eslint/member-ordering": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-param-reassign": "off",
+        "@typescript-eslint/no-parameter-properties": "off",
+        "@typescript-eslint/no-use-before-declare": "off",
+        "@typescript-eslint/promise-function-async": "off",
+        "@typescript-eslint/unbound-method": "off",
+        "arrow-body-style": "off",
+        "default-case": "off",
+        "linebreak-style": "off",
+        "no-bitwise": "off",
+        "no-empty": "off",
+        "no-empty-functions": "off",
         "no-magic-numbers": "off",
         "prefer-template": "off",
         "@typescript-eslint/tslint/config": [
             "error",
             {
-                rules: {
-                    "no-implicit-dependencies": [true, "dev"],
+                "rules": {
+                    "no-implicit-dependencies": [
+                        true,
+                        "dev"
+                    ],
                     "strict-boolean-expressions": [
                         true,
                         "allow-boolean-or-undefined",
-                        "allow-number",
-                    ],
-                },
-            },
-        ],
+                        "allow-number"
+                    ]
+                }
+            }
+        ]
+    },
+    "globals": {},
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
     },
+    "plugins": [
+        "@typescript-eslint",
+        "@typescript-eslint/tslint"
+    ],
+    "settings": {
+        "import/resolver": {
+            "node": {
+                "extensions": [
+                    ".mjs",
+                    ".js",
+                    ".json"
+                ]
+            }
+        },
+        "import/extensions": [
+            ".js",
+            ".mjs",
+            ".jsx"
+        ],
+        "import/core-modules": [],
+        "import/ignore": [
+            "node_modules",
+            "\\.(coffee|scss|css|less|hbs|svg|json)$"
+        ]
+    }
 };
diff --git a/test/tests/custom eslint path/stderr.txt b/test/tests/custom eslint path/stderr.txt
@@ -1,4 +0,0 @@
-❌ Could not start tslint-to-eslint: ❌
-Command failed: tslint --print-config "./tslint.json"
-Could not find configuration path. Try passing a --config to your tslint.json.
-
diff --git a/test/tests/custom eslint path/stdout.txt b/test/tests/custom eslint path/stdout.txt
@@ -0,0 +1,3 @@
+✨ 17 rules replaced with their ESLint equivalents. ✨
+️👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀
+✅ All is well! ✅
diff --git a/test/tests/custom package path/eslintrc.js b/test/tests/custom package path/eslintrc.js
@@ -0,0 +1,51 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint",
+        "@typescript-eslint/tslint"
+    ],
+    "rules": {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/interface-name-prefix": "error",
+        "@typescript-eslint/member-ordering": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-param-reassign": "off",
+        "@typescript-eslint/no-parameter-properties": "off",
+        "@typescript-eslint/no-use-before-declare": "off",
+        "@typescript-eslint/promise-function-async": "off",
+        "@typescript-eslint/unbound-method": "off",
+        "arrow-body-style": "off",
+        "default-case": "off",
+        "linebreak-style": "off",
+        "no-bitwise": "off",
+        "no-empty": "off",
+        "no-empty-functions": "off",
+        "no-magic-numbers": "off",
+        "prefer-template": "off",
+        "@typescript-eslint/tslint/config": [
+            "error",
+            {
+                "rules": {
+                    "no-implicit-dependencies": [
+                        true,
+                        "dev"
+                    ],
+                    "strict-boolean-expressions": [
+                        true,
+                        "allow-boolean-or-undefined",
+                        "allow-number"
+                    ]
+                }
+            }
+        ]
+    }
+};
diff --git a/test/tests/custom package path/stderr.txt b/test/tests/custom package path/stderr.txt
@@ -1,4 +0,0 @@
-❌ Could not start tslint-to-eslint: ❌
-Command failed: tslint --print-config "./tslint.json"
-Could not find configuration path. Try passing a --config to your tslint.json.
-
diff --git a/test/tests/custom package path/stdout.txt b/test/tests/custom package path/stdout.txt
@@ -0,0 +1,3 @@
+✨ 17 rules replaced with their ESLint equivalents. ✨
+️👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀
+✅ All is well! ✅
diff --git a/test/tests/custom typescript path/eslintrc.js b/test/tests/custom typescript path/eslintrc.js
@@ -0,0 +1,50 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "node": true
+    },
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint",
+        "@typescript-eslint/tslint"
+    ],
+    "rules": {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/interface-name-prefix": "error",
+        "@typescript-eslint/member-ordering": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-param-reassign": "off",
+        "@typescript-eslint/no-parameter-properties": "off",
+        "@typescript-eslint/no-use-before-declare": "off",
+        "@typescript-eslint/promise-function-async": "off",
+        "@typescript-eslint/unbound-method": "off",
+        "arrow-body-style": "off",
+        "default-case": "off",
+        "linebreak-style": "off",
+        "no-bitwise": "off",
+        "no-empty": "off",
+        "no-empty-functions": "off",
+        "no-magic-numbers": "off",
+        "prefer-template": "off",
+        "@typescript-eslint/tslint/config": [
+            "error",
+            {
+                "rules": {
+                    "no-implicit-dependencies": [
+                        true,
+                        "dev"
+                    ],
+                    "strict-boolean-expressions": [
+                        true,
+                        "allow-boolean-or-undefined",
+                        "allow-number"
+                    ]
+                }
+            }
+        ]
+    }
+};
diff --git a/test/tests/custom typescript path/expected.json b/test/tests/custom typescript path/expected.json
@@ -0,0 +1,31 @@
+module.exports = {
+    env: {
+        browser: true,
+        node: true,
+    },
+    parser: "@typescript-eslint/parser",
+    parserOptions: {
+        project: "tsconfig.json",
+        sourceType: "module",
+    },
+    plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
+    rules: {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/interface-name-prefix": "error",
+        "no-magic-numbers": "off",
+        "prefer-template": "off",
+        "@typescript-eslint/tslint/config": [
+            "error",
+            {
+                rules: {
+                    "no-implicit-dependencies": [true, "dev"],
+                    "strict-boolean-expressions": [
+                        true,
+                        "allow-boolean-or-undefined",
+                        "allow-number",
+                    ],
+                },
+            },
+        ],
+    },
+};
diff --git a/test/tests/custom typescript path/stderr.txt b/test/tests/custom typescript path/stderr.txt
diff --git a/test/tests/custom typescript path/stdout.txt b/test/tests/custom typescript path/stdout.txt
@@ -0,0 +1,3 @@
+✨ 17 rules replaced with their ESLint equivalents. ✨
+️👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀
+✅ All is well! ✅
diff --git a/test/tests/custom typescript path/test.ts b/test/tests/custom typescript path/test.ts
@@ -0,0 +1,5 @@
+import { createTests } from "../../createTests";
+
+createTests(__dirname, {
+    extraArgs: ["--typescript", "./tsconfig.custom.json"],
+});
diff --git a/test/tests/custom typescript path/tsconfig.custom.json b/test/tests/custom typescript path/tsconfig.custom.json
@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "lib": ["dom"]
+  }
+}
diff --git a/test/tests/custom typescript path/tslint.json b/test/tests/custom typescript path/tslint.json
diff --git a/test/tests/standalone tslint.json/eslintrc.js b/test/tests/standalone tslint.json/eslintrc.js
diff --git a/test/tests/standalone tslint.json/stderr.txt b/test/tests/standalone tslint.json/stderr.txt
diff --git a/test/tests/standalone tslint.json/stdout.txt b/test/tests/standalone tslint.json/stdout.txt

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+✨ 17 rules replaced with their ESLint equivalents. ✨`
	`2`	`+️👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀`
	`3`	`+✅ All is well! ✅`