Skip to content

Commit a00f90d

Browse files
committed
use --upgrade, remove -qq. remove unnecessary console.logs
1 parent 1b61cf1 commit a00f90d

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

index.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class PkgPyFuncs {
9090
}
9191

9292
let cmd = 'pip'
93-
let args = ['install', '-t', upath.normalize(buildPath), '-qq', '-r']
93+
let args = ['install', '--upgrade', '-t', upath.normalize(buildPath), '-r']
9494
if ( this.useDocker === true ){
9595
cmd = 'docker'
9696
args = ['exec', this.containerName, 'pip', ...args]
@@ -116,20 +116,18 @@ class PkgPyFuncs {
116116

117117
if (ret.stderr.length != 0){
118118
const errorText = ret.stderr.toString().trim()
119+
this.log(errorText) // prints stderr
119120
const countErrorNewLines = errorText.split('\n').length
120121

121122
if(countErrorNewLines < 2 && errorText.toLowerCase().includes('git clone')){
122123
// Ignore false positive due to pip git clone printing to stderr
123-
console.log(errorText)
124124
} else if(errorText.toLowerCase().includes('docker')){
125125
console.log('stdout:', out)
126-
console.log('stderr: ', errorText)
127126
this.error("Docker Error Detected")
128127

129128
} else {
130129
// Error is not false positive,
131130
console.log('___ERROR DETECTED, BEGIN STDOUT____\n', out)
132-
console.log('---BEGIN STDERR---\n', errorText)
133131
this.requestUserConfirmation()
134132
}
135133

@@ -156,7 +154,6 @@ class PkgPyFuncs {
156154
setupContainer(){
157155
let out = this.runProcess('docker',['ps', '-a', '--filter',`name=${this.containerName}`,'--format','{{.Names}}'])
158156
out = out.replace(/^\s+|\s+$/g, '')
159-
console.log('SDLFKJSDL:KFJSDL:KFJ ', this.containerName)
160157

161158
if ( out === this.containerName ){
162159
this.log('Container already exists. Reusing.')

0 commit comments

Comments
 (0)