Skip to content

Update uisref on param changing, not only state #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update uisref on param changing, not only state #976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ccd01
Update uisref on param changing, not only state
oBusk Jan 11, 2023
0ebf4c1
Fix typo
oBusk Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/directives/uiSref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ export class UISref implements OnChanges {

/** @internal */ private _emit = false;
/** @internal */ private _statesSub: Subscription;
/** @internal */ private _paramsSub: Subscription;
/** @internal */ private _router: UIRouter;
/** @internal */ private _anchorUISref: AnchorUISref;
/** @internal */ private _parent: ParentUIViewInject;
Expand All @@ -129,6 +130,7 @@ export class UISref implements OnChanges {
this._parent = parent;

this._statesSub = _router.globals.states$.subscribe(() => this.update());
this._statesSub = _router.globals.params$.subscribe(() => this.update());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was supposed to be _paramsSub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was definitely my intention 😅 Fixed it! (0ebf4c1)

}

/** @internal */
Expand Down Expand Up @@ -159,6 +161,7 @@ export class UISref implements OnChanges {
ngOnDestroy() {
this._emit = false;
this._statesSub.unsubscribe();
this._paramsSub.unsubscribe();
this.targetState$.unsubscribe();
}

Expand Down