-
Notifications
You must be signed in to change notification settings - Fork 56
Adjust color slider with min and max #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adjusts the color slider component to properly handle min and max values for opacity sliders, fixing a bug where opacity gradients were not respecting these boundaries.
- Updates the opacity gradient calculation to use RGB values and respect max values
- Adds new story examples to demonstrate min and max functionality for opacity sliders
- Refactors gradient styling to use CSS custom properties for better maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
uui-color-slider.story.ts | Adds new story examples for hue slider and opacity sliders with min/max constraints |
uui-color-slider.element.ts | Updates opacity gradient calculation to use RGB values and respect max property, refactors to use CSS custom properties |
Comments suppressed due to low confidence (1)
packages/uui-color-slider/lib/uui-color-slider.element.ts:133
- The variable name 'hueColor' is misleading as this is actually calculating an opacity gradient, not a hue-related color. Consider renaming to 'opacityGradient' for clarity.
const hueColor =
|
@iOvergaard I have seen some libraries separating these - or having a base slider and "alpha", "hue" slider extending the base color slider, similar to boolean input. It may make sense as e.g. with "hue" slider is doesn't make much sense to change "min" (0) and "max" (360) values. In Fluent UI it has a separate component for "alpha" slider, while another "color" slider has a property "channel" = hue, saturation etc, Something to consider. |
Description
Besides #1149 this also adjust color slider, when setting
min
andmax
to different that defaults for opacity slider.E.g. a color slider allowing value within range
0-50
or50-100
. The range from50-100
behaves a bit strange at handle stops as 50% from left, where it is expected left position should be0%
, but with 50 as value.Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist