Skip to content

Commit 33be385

Browse files
committed
breaking changes
1 parent 8ef3243 commit 33be385

File tree

7 files changed

+14
-16
lines changed

7 files changed

+14
-16
lines changed

contrib/cabal.project

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
packages:
2+
../fuzzyfind
23
codebase2/codebase
34
codebase2/codebase-sqlite
45
codebase2/codebase-sqlite-hashing-v2
@@ -50,7 +51,7 @@ source-repository-package
5051
constraints:
5152
fsnotify < 0.4,
5253
crypton-x509-store <= 1.6.8,
53-
servant <= 0.19.1,
54+
servant <= 0.20.1,
5455
optparse-applicative <= 0.17.1.0
5556

5657
-- For now there is no way to apply ghc-options for all local packages

lib/unison-sqlite/src/Unison/Sqlite/Connection.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,9 @@ execute conn@(Connection _ _ conn0) sql@(Sql s params) = do
172172
--
173173
-- This function does not support parameters, and is mostly useful for executing DDL and migrations.
174174
executeStatements :: Connection -> Text -> IO ()
175-
executeStatements conn@(Connection _ _ (Sqlite.Connection database)) sql = do
175+
executeStatements conn@(Connection _ _ connection) sql = do
176176
logQuery (Sql sql []) Nothing
177-
Direct.Sqlite.exec database sql `catch` \(exception :: Sqlite.SQLError) ->
177+
Direct.Sqlite.exec (Sqlite.connectionHandle connection) sql `catch` \(exception :: Sqlite.SQLError) ->
178178
throwSqliteQueryException
179179
SqliteQueryExceptionInfo
180180
{ connection = conn,

parser-typechecker/src/Unison/Runtime/MCode.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ module Unison.Runtime.MCode
3636
)
3737
where
3838

39-
import Control.Applicative (liftA2)
4039
import Data.Bifunctor (bimap, first)
4140
import Data.Bits (shiftL, shiftR, (.|.))
4241
import Data.Coerce

parser-typechecker/src/Unison/Runtime/Serialize.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
module Unison.Runtime.Serialize where
44

5-
import Control.Applicative (liftA2)
65
import Control.Monad (replicateM)
76
import Data.Bits (Bits)
87
import Data.ByteString qualified as B

unison-cli/src/Unison/Cli/Share/Projects.hs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -256,10 +256,9 @@ servantClientToCli action = do
256256
let clientEnv :: ClientEnv
257257
clientEnv =
258258
(mkClientEnv httpManager hardCodedBaseUrl)
259-
{ Servant.makeClientRequest = \url request ->
260-
(Servant.defaultMakeClientRequest url request)
261-
{ Http.Client.responseTimeout = Http.Client.responseTimeoutMicro (60 * 1000 * 1000 {- 60s -})
262-
}
259+
{ Servant.makeClientRequest = \url request -> do
260+
defaultRequest <- (Servant.defaultMakeClientRequest url request)
261+
return defaultRequest { Http.Client.responseTimeout = Http.Client.responseTimeoutMicro (60 * 1000 * 1000 {- 60s -}) }
263262
}
264263

265264
liftIO (runClientM action clientEnv)

unison-cli/src/Unison/Share/Sync.hs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,10 +1051,10 @@ httpUploadEntities ::
10511051
go f (Auth.AuthenticatedHttpClient httpClient) unisonShareUrl req =
10521052
(Servant.mkClientEnv httpClient unisonShareUrl)
10531053
{ Servant.makeClientRequest = \url request ->
1054-
-- Disable client-side timeouts
1055-
(Servant.defaultMakeClientRequest url request)
1056-
{ Http.Client.responseTimeout = Http.Client.responseTimeoutNone
1057-
}
1054+
do
1055+
-- Disable client-side timeouts
1056+
defaultRequest <- (Servant.defaultMakeClientRequest url request)
1057+
return defaultRequest {Http.Client.responseTimeout = Http.Client.responseTimeoutNone}
10581058
}
10591059
& runReaderT (f req)
10601060
& runExceptT

unison-cli/unison-cli.cabal

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ library
236236
, semialign
237237
, semigroups
238238
, servant
239-
, servant-client
239+
, servant-client >=0.20
240240
, shellmet
241241
, stm
242242
, template-haskell
@@ -378,7 +378,7 @@ executable transcripts
378378
, semialign
379379
, semigroups
380380
, servant
381-
, servant-client
381+
, servant-client >=0.20
382382
, shellmet
383383
, silently
384384
, stm
@@ -526,7 +526,7 @@ test-suite cli-tests
526526
, semialign
527527
, semigroups
528528
, servant
529-
, servant-client
529+
, servant-client >=0.20
530530
, shellmet
531531
, stm
532532
, template-haskell

0 commit comments

Comments
 (0)