Making extension methods obsolete

Author: ENikS

src/Container/IContainerContext.cs

@@ -17,15 +17,6 @@ public interface IContainerContext
         IUnityContainer Container { get; }
 
         /// <summary>
-        /// Retrieves registration for requested named type
-        /// </summary>
-        /// <param name="type">Registration type</param>
-        /// <param name="name">Registration name</param>
-        /// <param name="create">Instruncts container if it should create registration if not found</param>
-        /// <returns>Registration for requested named type or null if named type is not registered and <see cref="create"/> is false</returns>
-        IRegistration Registration(Type type, string name, bool create = false);
-
-            /// <summary>
         /// Generic method to retrieve policy for registered named type.
         /// </summary>
         /// <typeparam name="TPolicy">Type of the policy to retrieve</typeparam>

src/Registration/IContainerRegistration.cs

@@ -8,11 +8,11 @@ namespace Unity.Registration
     /// <summary>
     /// Information about the types registered in a container.
     /// </summary>
-    public interface IContainerRegistration : IRegistration
+    public interface IContainerRegistration : INamedType
     {
         /// <summary>
         /// The type that this registration is mapped to. If no type mapping was done, the
-        /// <see cref="IRegistration.RegisteredType"/> property and this one will have the same value.
+        /// <see cref="INamedType.RegisteredType"/> property and this one will have the same value.
         /// </summary>
         Type MappedToType { get; }
 

src/Registration/INamedType.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Unity.Registration
+{
+    /// <summary>
+    /// Basic information about registered type
+    /// </summary>
+    public interface INamedType
+    {
+        /// <summary>
+        /// Type of the registration.
+        /// </summary>
+        Type RegisteredType { get; }
+
+        /// <summary>
+        /// Name the registered type. Null for default registration.
+        /// </summary>
+        string Name { get; }
+    }
+}

src/Registration/IRegistration.cs

@@ -5,7 +5,7 @@ namespace Unity.Registration
     /// <summary>
     /// Basic information about registered type
     /// </summary>
-    public interface IRegistration
+    public interface I_Registration
     {
         /// <summary>
         /// Type of the registration.

src/Utility/PolicyListExtensions.cs

@@ -21,6 +21,7 @@ public static class PolicyListExtensions
         /// <param name="policies"></param>
         /// <param name="policyInterface">The type of policy to remove.</param>
         /// <param name="buildKey">The key the policy applies.</param>
+        [Obsolete("Use IPolicyList.Clear(...)")]
         public static void Clear(this IPolicyList policies, Type policyInterface, object buildKey)
         {
             var key = ParseBuildKey(buildKey);
@@ -33,6 +34,7 @@ public static void Clear(this IPolicyList policies, Type policyInterface, object
         /// <typeparam name="TPolicyInterface">The type the policy was registered as.</typeparam>
         /// <param name="policies"><see cref="IPolicyList"/> to remove the policy from.</param>
         /// <param name="buildKey">The key the policy applies.</param>
+        [Obsolete("Use IPolicyList.Clear(...)")]
         public static void Clear<TPolicyInterface>(this IPolicyList policies, object buildKey)
             where TPolicyInterface : IBuilderPolicy
         {
@@ -45,6 +47,7 @@ public static void Clear<TPolicyInterface>(this IPolicyList policies, object bui
         /// </summary>
         /// <typeparam name="TPolicyInterface">The type the policy was registered as.</typeparam>
         /// <param name="policies"><see cref="IPolicyList"/> to remove the policy from.</param>
+        [Obsolete("Use IPolicyList.Clear(null, null, ...)")]
         public static void ClearDefault<TPolicyInterface>(this IPolicyList policies)
             where TPolicyInterface : IBuilderPolicy
         {
@@ -57,6 +60,7 @@ public static void ClearDefault<TPolicyInterface>(this IPolicyList policies)
         /// </summary>
         /// <param name="policies"></param>
         /// <param name="policyInterface">The type the policy was registered as.</param>
+        [Obsolete("Use IPolicyList.Clear(null, null, ...)")]
         public static void ClearDefault(this IPolicyList policies, Type policyInterface)
         {
             (policies ?? throw new ArgumentNullException(nameof(policies))).Clear(null, null, policyInterface);
@@ -74,6 +78,7 @@ public static void ClearDefault(this IPolicyList policies, Type policyInterface)
         /// <param name="policyInterface">The <see cref="Type"/> of the policy.</param>
         /// <param name="policy">The policy to be registered.</param>
         /// <param name="buildKey">The key the policy applies.</param>
+        [Obsolete("Use IPolicyList.Set(...)")]
         public static void Set(this IPolicyList policies, Type policyInterface, IBuilderPolicy policy, object buildKey = null)
         {
             var key = ParseBuildKey(buildKey);
@@ -133,6 +138,7 @@ public static void SetDefault<TPolicyInterface>(this IPolicyList policies, TPoli
         /// <param name="policyInterface">The interface the policy is registered under.</param>
         /// <param name="buildKey">The key the policy applies.</param>
         /// <returns>The policy in the list, if present; returns null otherwise.</returns>
+        [Obsolete("Use IPolicyList.Get(...)")]
         public static IBuilderPolicy Get(this IPolicyList policies, Type policyInterface, object buildKey)
         {
             return (policies ?? throw new ArgumentNullException(nameof(policies))).GetOrDefault(policyInterface, buildKey, out IPolicyList _);