fixes #23 - handle hexadecimal encoded files such as %2B (+) and %40 (@) in connection name

Author: PhilippSalvisberg

sqldev/src/main/java/org/utplsql/sqldev/model/URLTools.xtend

@@ -18,11 +18,24 @@ import java.net.URL
 import java.util.regex.Pattern
 
 class URLTools {
+	def replaceHexChars(String input) {
+		var String output = input;
+		val p = Pattern.compile("%([0-9A-F]{2})")
+		val m = p.matcher(input)
+		while (m.find) {
+			val what = m.group(0);
+			val decimal = Integer.parseInt(m.group(1), 16)
+			val with = String.valueOf(decimal as char)
+			output = output.replace(what, with)
+		}
+		return output
+	}
+	
 	def getConnectionName(URL url) {
 		val p = Pattern.compile("(sqldev.nav:)([^/]+)(//)?")
 		val m = p.matcher(url.toString)
 		if (m.find) {
-			return m.group(2).replace("IdeConnections%2523", "IdeConnections%23").replace("%2B", "+")
+			return m.group(2).replace("IdeConnections%2523", "IdeConnections%23").replaceHexChars
 		} else {
 			return ""
 		}		

sqldev/src/test/java/org/utplsql/sqldev/tests/UrlToolsTest.xtend

@@ -0,0 +1,31 @@
+package org.utplsql.sqldev.tests
+
+import org.junit.Assert
+import org.junit.Test
+import org.utplsql.sqldev.model.URLTools
+
+class UrlToolsTest {
+	private val extension URLTools urlTools = new URLTools
+
+	@Test
+	def void testReplacePlusSign() {
+		Assert.assertEquals("+", "%2B".replaceHexChars)
+		Assert.assertEquals("++", "%2B%2B".replaceHexChars)
+		Assert.assertEquals("abc+%xyz", "abc%2B%xyz".replaceHexChars)
+	}
+
+	@Test
+	def void testReplaceAtSign() {
+		Assert.assertEquals("@", "%40".replaceHexChars)
+		Assert.assertEquals("@@", "%40%40".replaceHexChars)
+		Assert.assertEquals("abc@%xyz", "abc%40%xyz".replaceHexChars)
+	}
+
+	@Test
+	def void testReplaceAtAndPlusSign() {
+		Assert.assertEquals("@+", "%40%2B".replaceHexChars)
+		Assert.assertEquals("@+@+", "%40%2B%40%2B".replaceHexChars)
+		Assert.assertEquals("abc@+%xyz", "abc%40%2B%xyz".replaceHexChars)
+	}
+
+}