Skip to content

Conversation

@elf-pavlik
Copy link

Currently I only extend the SessionCore class for initial implementation of session which uses self issued tokens in CSS instance that acts as the OP.
I know that you want to focus on a browser but AFAIK there thould be no problem with this change.

Currently I needed to copy & paste _createSignedDPoPToken method into my sublcass and @ts-ignore bunch of errors about accessing private properties. It still works as an early draft 🐱

@uvdsl
Copy link
Owner

uvdsl commented Nov 7, 2025

Hi pavlik, thank you for this PR.
I think, technically, this should be fine - however some gut feeling keeps me from merging.
It feels odd to mix window (as in window.location.href ) with globalThis (as you suggest for globalThis.crypto).
I'll need to look into this.

@elf-pavlik
Copy link
Author

Sure, no rush. for now I can continue with what I have. If you want your code to exclusively work in a web browser it probably doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants