chore: upgrade vaadin-testbench to 8.3.1 (23.6) (#8256) (#8258)

* chore: upgrade vaadin-testbench to 8.3.1

* fix: do not modify location

Author: ZheSun88

pom.xml

@@ -13,7 +13,7 @@
     <url>https://vaadin.com/components</url>
     <properties>
         <flow.version>23.7-SNAPSHOT</flow.version>
-        <testbench.version>8.3.0</testbench.version>
+        <testbench.version>8.3.1</testbench.version>
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-testbench/src/main/java/com/vaadin/flow/component/spreadsheet/testbench/SpreadsheetElement.java

@@ -293,9 +293,10 @@ private void scrollSheetVisible(WebElement targetSheet) {
     boolean isElementSelected(WebElement element) {
         updateSelectionLocationAndSize();
         Point location = element.getLocation();
-        location.x += element.getSize().getWidth() / 2;
-        location.y += element.getSize().getHeight() / 2;
-        return isInSelection(location) || isNonCoherentlySelected(element);
+        int centerX = location.x + element.getSize().getWidth() / 2;
+        int centerY = location.y + element.getSize().getHeight() / 2;
+        return isInSelection(centerX, centerY)
+                || isNonCoherentlySelected(element);
     }
 
     private void findSelectionOutline() {
@@ -329,15 +330,14 @@ private void updateSelectionLocationAndSize() {
                 bottomY + bottomH - sLocation.getY());
     }
 
-    private boolean isInSelection(Point location) {
+    private boolean isInSelection(int locationX, int locationY) {
         // Test top left corner
-        if (location.getX() < sLocation.getX()
-                || location.getY() < sLocation.getY()) {
+        if (locationX < sLocation.getX() || locationY < sLocation.getY()) {
             return false;
         }
         // Test lower right corner
-        if (location.getX() - sLocation.getX() > sSize.getWidth()
-                || location.getY() - sLocation.getY() > sSize.getHeight()) {
+        if (locationX - sLocation.getX() > sSize.getWidth()
+                || locationY - sLocation.getY() > sSize.getHeight()) {
             return false;
         }
         // Everything is inside the selection