test: refactor Spreadsheet icon test #8335
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
approved these changes
Dec 8, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 8, 2025
DiegoCardoso
added a commit
that referenced
this pull request
Dec 8, 2025
DiegoCardoso
added a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the new tests added in #8303 is flaky. The build log to in Bender doesn't give a clear insight of the reason other than the element not being found, but there's no screenshot recorded. Trying to fix it by refactoring the logic to fetch the
vaadin-iconelement by replacing the XPath query with a query for the elements by class/tag name to see if it helps.