wait for selector in waitForServerReady (wildfly), add commons (copilot)

Author: manolo

scripts/pit/its/hello.js

@@ -5,16 +5,14 @@ const { log, args, createPage, closePage, takeScreenshot, waitForServerReady, di
 
     const page = await createPage(arg.headless);
 
-    await waitForServerReady(page, arg.url);
+    // Wait for server and vaadin ready
+    await waitForServerReady(page, arg.url, {selector: '#outlet > * > *:not(style):not(script)'});
 
     // Dismiss dev mode notification if present
     await dismissDevmode(page);
 
     const text = 'Greet';
 
-    // Wait for vaadin ready
-    await page.waitForSelector('#outlet > * > *:not(style):not(script)');
-
     await takeScreenshot(page, __filename, 'initial-view');
 
     // Click input[type="text"]

scripts/pit/its/test-utils.js

@@ -173,18 +173,22 @@ function getCallingTestFile() {
 // Wait for the server to be ready and to get a valid response
 async function waitForServerReady(page, url, options = {}) {
   const {
+    selector,
     maxRetries = 35, // Max number of retries
     retryInterval = 5000 // Interval between retries in milliseconds
   } = options;
-
   log(`Opening ${url}\n`);
   for (let attempt = 0; attempt < maxRetries; attempt++) {
     await page.goto('about:blank');
     try {
       const response = await page.goto(url, {timeout: 5000});
       // Check if the response status is not 503
       if (response && response.status() < 400) {
-        await page.waitForTimeout(1000);
+        if (options.selector) {
+          await page.waitForSelector(selector, {timeout: 1000});
+        } else {
+          await page.waitForTimeout(1000);
+        }
         ok(` ✓ Attempt ${attempt} Server is ready and returned a valid response. ${response.status()}\n`);
         await takeScreenshot(page, getCallingTestFile(), 'ss', '_before');
         return response;

scripts/pit/lib/lib-patch-v25.sh

@@ -59,6 +59,10 @@ applyv25patches() {
       ## TODO: check that documentation mention elemental is not a transitive dep anymore
       addMavenDep "com.google.gwt" "gwt-elemental" compile '\<version\>2.9.0\</version\>'
       ;;
+    flow-quickstart-tutorial) 
+      addMavenDep "commons-io" "commons-io" "compile"
+      addGradleDep "commons-io" "commons-io"
+      ;;
   esac
 
   case $vers_ in
@@ -514,6 +518,7 @@ replaceVaadinSpringWithStarter() {
   fi
 }
 
+
 ## Adds vaadin-dev dependency for projects without Spring
 ## Checks if Spring is not present in build files and adds vaadin-dev dependency
 ## TODO: verify that is explained in migration guide
@@ -542,6 +547,8 @@ addDevModeIfNeeded() {
     fi
 }
 
+
+
 ## Adds Hilla Spring Boot Starter dependency if project uses Hilla
 ## Checks for Java files with Hilla imports or TypeScript files in views directories
 ## TODO: verify that is explained in migration guide
@@ -626,3 +633,4 @@ addGradleDep() {
 
 
 
+