Skip to content

Commit 324e34c

Browse files
committed
use flag --screenshots in its
1 parent 0fe4e79 commit 324e34c

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

scripts/pit/its/test-utils.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ const args = () => {
106106
ret.prefix = a.split('=')[1];
107107
} else if (/^--name=/.test(a)) {
108108
ret.name = a.split('=')[1];
109+
} else if (/^--screenshots/.test(a)) {
110+
ret.screenshot = true;
109111
}
110112
});
111113
if (!ret.url) {
@@ -133,7 +135,9 @@ async function createPage(headless, ignoreHTTPSErrors) {
133135
return page;
134136
}
135137
async function closePage(page, arg) {
136-
await takeScreenshot(page, arg, getCallingTestFile(), 'after');
138+
if (arg.screenshot) {
139+
await takeScreenshot(page, arg, getCallingTestFile(), 'after');
140+
}
137141
await page.goto('about:blank');
138142
await page.context().close();
139143
await page.browser.close();
@@ -190,7 +194,9 @@ async function waitForServerReady(page, url, arg, options = {}) {
190194
await page.waitForTimeout(1000);
191195
}
192196
ok(` ✓ Attempt ${attempt} Server is ready and returned a valid response. ${response.status()}\n`);
193-
await takeScreenshot(page, arg, getCallingTestFile(), 'before');
197+
if (arg.screenshot) {
198+
await takeScreenshot(page, arg, getCallingTestFile(), 'before');
199+
}
194200
return response;
195201
} else {
196202
out(` ⏲ Attempt ${attempt} Server is not ready yet. ${response.status()}\n`);
@@ -204,7 +210,9 @@ async function waitForServerReady(page, url, arg, options = {}) {
204210
}
205211
await page.waitForTimeout(retryInterval);
206212
}
207-
await takeScreenshot(page, arg, getCallingTestFile(), 'before');
213+
if (arg.screenshot) {
214+
await takeScreenshot(page, arg, getCallingTestFile(), 'before');
215+
}
208216
throw new Error(`Server did not become ready after ${maxRetries} attempts.\n`);
209217
}
210218

scripts/pit/lib/lib-playwright.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ runPlaywrightTests() {
4242
[ -f "$_test_file" ] && checkPlaywrightInstallation "$_test_file" || return 0
4343

4444
_args="$* --name=$_name --version=$_version --mode=$_mode"
45+
[ -n "$SCREENSHOTS" ] && _args="$_args --screenshots"
46+
4547
isHeadless && _args="$_args --headless"
4648
log "Running visual test: $_base_name"
4749
PATH=$PATH START=$START runToFile "'$NODE' '$_test_file' $_args" "$_pfile" "$VERBOSE" true

0 commit comments

Comments
 (0)