wait for selector in waitForServerReady, for fixing wildfly

Author: manolo

scripts/pit/its/hello.js

@@ -5,16 +5,14 @@ const { log, args, createPage, closePage, takeScreenshot, waitForServerReady, di
 
     const page = await createPage(arg.headless);
 
-    await waitForServerReady(page, arg.url);
+    // Wait for server and vaadin ready
+    await waitForServerReady(page, arg.url, {selector: '#outlet > * > *:not(style):not(script)'});
 
     // Dismiss dev mode notification if present
     await dismissDevmode(page);
 
     const text = 'Greet';
 
-    // Wait for vaadin ready
-    await page.waitForSelector('#outlet > * > *:not(style):not(script)');
-
     await takeScreenshot(page, __filename, 'initial-view');
 
     // Click input[type="text"]

scripts/pit/its/test-utils.js

@@ -173,6 +173,7 @@ function getCallingTestFile() {
 // Wait for the server to be ready and to get a valid response
 async function waitForServerReady(page, url, options = {}) {
   const {
+    selector,
     maxRetries = 35, // Max number of retries
     retryInterval = 5000 // Interval between retries in milliseconds
   } = options;
@@ -184,10 +185,15 @@ async function waitForServerReady(page, url, options = {}) {
       const response = await page.goto(url, {timeout: 5000});
       // Check if the response status is not 503
       if (response && response.status() < 400) {
-        await page.waitForTimeout(1000);
-        ok(` ✓ Attempt ${attempt} Server is ready and returned a valid response. ${response.status()}\n`);
-        await takeScreenshot(page, getCallingTestFile(), 'ss', '_before');
-        return response;
+        try {
+          await page.waitForSelector(selector, {timeout: 1000});
+          await page.waitForTimeout(1000);
+          ok(` ✓ Attempt ${attempt} Server is ready and returned a valid response. ${response.status()}\n`);
+          await takeScreenshot(page, getCallingTestFile(), 'ss', '_before');
+          return response;
+        } catch (error) {
+          out(` ⏲ Attempt ${attempt} Server is not ready yet. ${error}\n`);
+        }
       } else {
         out(` ⏲ Attempt ${attempt} Server is not ready yet. ${response.status()}\n`);
       }