migrate scripts/pit/its/start.js to use test-utils

Author: manolo

scripts/pit/its/start.js

@@ -1,45 +1,33 @@
-const { chromium } = require('playwright');
-
-let headless = false, host = 'localhost', port = '8080', hub = false;
-process.argv.forEach(a => {
-  if (/^--headless/.test(a)) {
-    headless = true;
-  } else if (/^--ip=/.test(a)) {
-    ip = a.split('=')[1];
-  } else if (/^--port=/.test(a)) {
-    port = a.split('=')[1];
-  }
-});
+const { log, args, createPage, closePage, takeScreenshot, waitForServerReady, dismissDevmode } = require('./test-utils');
 
 (async () => {
-  const browser = await chromium.launch({
-    headless: headless,
-    chromiumSandbox: false
-  });
-  
-  // TODO: should work with smaller viewport too like in 24.9
-  const context = await browser.newContext({
-    viewport: { width: 1920, height: 1080 }
-  });
+    const arg = args();
+
+    const page = await createPage(arg.headless);
+    // TODO: should work with smaller viewport too like in 24.9
+    page.setViewportSize({ width: 1920, height: 1080 });
 
-  const page = await context.newPage();
-  page.on('console', msg => console.log("> CONSOLE:", (msg.text() + ' - ' + msg.location().url).replace(/\s+/g, ' ')));
-  page.on('pageerror', err => console.log("> PAGEERROR:", ('' + err).replace(/\s+/g, ' ')));
+    await waitForServerReady(page, arg.url);
 
-  await page.goto(`http://${host}:${port}/`);
+    // Dismiss dev mode notification if present
+    await dismissDevmode(page);
+    await takeScreenshot(page, __filename, 'page-loaded');
 
-  await page.locator('text=Hello').nth(0).click();
-  await page.locator('input[type="text"]').fill('Greet');
-  await page.locator('text=Say hello').click();
-  await page.locator('text=Hello Greet');
+    log('Testing Hello functionality');
+    await page.locator('text=Hello').nth(0).click();
+    await page.locator('input[type="text"]').fill('Greet');
+    await page.locator('text=Say hello').click();
+    await page.locator('text=Hello Greet');
+    await takeScreenshot(page, __filename, 'hello-tested');
 
-  await page.locator('text=Master-Detail').nth(0).click();
-  await page.locator('text=eula.lane').click();
-  await page.locator('input[type="text"]').nth(0).fill('FOO');
-  await page.locator('text=Save').click();
-  await page.locator('text=/stored/');
+    log('Testing Master-Detail functionality');
+    await page.locator('text=Master-Detail').nth(0).click();
+    await page.locator('text=eula.lane').click();
+    await page.locator('input[type="text"]').nth(0).fill('FOO');
+    await page.locator('text=Save').click();
+    await page.locator('text=/stored/');
+    await takeScreenshot(page, __filename, 'master-detail-tested');
 
-  // ---------------------
-  await context.close();
-  await browser.close();
+    log('Start application tested successfully');
+    await closePage(page);
 })();

scripts/pit/its/test-utils.js

@@ -133,6 +133,7 @@ async function createPage(headless, ignoreHTTPSErrors) {
     return page;
 }
 async function closePage(page) {
+    await takeScreenshot(page, getCallingTestFile(), 'ss', '_after');
     await page.goto('about:blank');
     await page.context().close();
     await page.browser.close();
@@ -152,6 +153,23 @@ async function takeScreenshot(page, name, descr, prefix) {
   out(` 📸 Screenshot taken: ${file}\n`);
 }
 
+// Helper function to get the calling test file name
+function getCallingTestFile() {
+  const stack = new Error().stack;
+  const stackLines = stack.split('\n');
+
+  // Look for the first line that contains a .js file that's not test-utils.js
+  for (const line of stackLines) {
+    if (line.includes('.js') && !line.includes('test-utils.js') && !line.includes('node_modules')) {
+      const match = line.match(/\/([^\/]+\.js)/);
+      if (match) {
+        return match[1].replace('.js', '');
+      }
+    }
+  }
+  return '';
+}
+
 // Wait for the server to be ready and to get a valid response
 async function waitForServerReady(page, url, options = {}) {
   const {
@@ -168,6 +186,7 @@ async function waitForServerReady(page, url, options = {}) {
       if (response && response.status() < 400) {
         await page.waitForTimeout(1000);
         ok(` ✓ Attempt ${attempt} Server is ready and returned a valid response. ${response.status()}\n`);
+        await takeScreenshot(page, getCallingTestFile(), 'ss', '_before');
         return response;
       } else {
         out(` ⏲ Attempt ${attempt} Server is not ready yet. ${response.status()}\n`);
@@ -181,6 +200,7 @@ async function waitForServerReady(page, url, options = {}) {
     }
     await page.waitForTimeout(retryInterval);
   }
+  await takeScreenshot(page, getCallingTestFile(), 'ss', '_before');
   throw new Error(`Server did not become ready after ${maxRetries} attempts.\n`);
 }