fix: update common, clean out dead code and get linting working (#52)

Signed-off-by: Chris Butler <chris.butler@redhat.com>

Author: butler54

.ansible-lint

@@ -1,14 +1,15 @@
 # Vim filetype=yaml
 ---
 offline: false
-#requirements: ansible/execution_environment/requirements.yml
 
 exclude_paths:
   - .cache/
   - .github/
   - charts/
   - common/
   - tests/
+  - requirements.yml
+  - values-*
 
 # warn_list:
 #   - yaml

.flake8

@@ -0,0 +1,3 @@
+[flake8]
+# match black default
+max-line-length = 88

.github/workflows/ansible-lint.yml

@@ -11,7 +11,5 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Lint Ansible Playbook
-        uses: ansible/ansible-lint-action@v6
-        # Let's point it to the path
-        with:
-          path: "ansible/"
+        uses: ansible/ansible-lint@06f616d6e86e9ce4c74393318d1cbb2d016af413
+        # Let's point it to the path

.github/workflows/jsonschema.yaml

@@ -1,41 +1,19 @@
 ---
 name: Verify json schema
 
-#
-# Documentation:
-# https://help.github.com/en/articles/workflow-syntax-for-github-actions
-#
-
-#############################
-# Start the job on all push #
-#############################
 on: [push, pull_request]
 
-###############
-# Set the Job #
-###############
 jobs:
   jsonschema_tests:
-    # Name the Job
     name: Json Schema tests
     strategy:
       matrix:
         python-version: [3.11]
-    # Set the agent to run on
     runs-on: ubuntu-latest
 
-    ##################
-    # Load all steps #
-    ##################
     steps:
-      ##########################
-      # Checkout the code base #
-      ##########################
       - name: Checkout Code
         uses: actions/checkout@v4
-        with:
-          # Full git history is needed to get a proper list of changed files within `super-linter`
-          fetch-depth: 0
 
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v5
@@ -54,19 +32,19 @@ jobs:
 
       - name: Verify secrets json schema against templates
         run: |
-          # check-jsonschema needs .yaml as an extension
           cp ./values-secret.yaml.template ./values-secret.yaml
-          check-jsonschema --schemafile ./common/ansible/roles/vault_utils/values-secrets.v2.schema.json values-secret.yaml
+          check-jsonschema --fill-defaults --schemafile https://raw.githubusercontent.com/validatedpatterns/rhvp.cluster_utils/refs/heads/main/roles/vault_utils/values-secrets.v2.schema.json values-secret.yaml
           rm -f ./values-secret.yaml
 
       - name: Verify ClusterGroup values.schema.json against values-*yaml files
         run: |
-          set -e; for i in values-hub.yaml values-group-one.yaml; do
+          set -e
+          find . -maxdepth 1 -type f -name "values-*.yaml" ! -name "values-global.yaml" -print0 | while IFS= read -r -d '' i;
+          do
             echo "$i"
             # disable shellcheck of single quotes in yq
             # shellcheck disable=2016
             yq eval-all '. as $item ireduce ({}; . * $item )' values-global.yaml "$i" > tmp.yaml
-            check-jsonschema --schemafile ./common/clustergroup/values.schema.json tmp.yaml
+            check-jsonschema --fill-defaults --schemafile https://raw.githubusercontent.com/validatedpatterns/clustergroup-chart/refs/heads/main/values.schema.json tmp.yaml
             rm -f tmp.yaml
-          done
-
+          done

.github/workflows/linter.yml

@@ -21,7 +21,7 @@ jobs:
       # Run Linter against code base #
       ################################
       - name: Lint Code Base
-        uses: github/super-linter/slim@v6
+        uses: super-linter/super-linter/slim@v7
         env:
           VALIDATE_ALL_CODEBASE: true
           DEFAULT_BRANCH: main
@@ -31,11 +31,14 @@ jobs:
           VALIDATE_BASH: false
           VALIDATE_CHECKOV: false
           VALIDATE_JSCPD: false
+          VALIDATE_JSON_PRETTIER: false
+          VALIDATE_MARKDOWN_PRETTIER: false
           VALIDATE_KUBERNETES_KUBECONFORM: false
           VALIDATE_PYTHON_PYLINT: false
           VALIDATE_SHELL_SHFMT: false
           VALIDATE_YAML: false
+          VALIDATE_YAML_PRETTIER: false
           # VALIDATE_DOCKERFILE_HADOLINT: false
           # VALIDATE_MARKDOWN: false
           # VALIDATE_NATURAL_LANGUAGE: false
-          # VALIDATE_TEKTON: false
+          # VALIDATE_TEKTON: false

.github/workflows/superlinter.yml

@@ -19,3 +19,4 @@ azure-env.sh
 openshift-install
 node_modules
 .envrc
+.ansible/

.gitignore

@@ -0,0 +1,4 @@
+{
+  "singleQuote": true,
+  "semi": false
+}

.prettierrc

@@ -1,7 +1,7 @@
 branches:
-- main
+  - main
 plugins:
-- "@semantic-release/commit-analyzer"
-- "@semantic-release/release-notes-generator"
-- "@semantic-release/github"
-- "@semantic-release/git"
+  - "@semantic-release/commit-analyzer"
+  - "@semantic-release/release-notes-generator"
+  - "@semantic-release/github"
+  - "@semantic-release/git"