-
-
Notifications
You must be signed in to change notification settings - Fork 37
Closed
Labels
enhancementNew feature of requestNew feature of requestin progressThis issue is being actively worked onThis issue is being actively worked on
Description
Currently the PyNomaly library is using a validation class that offers several methods that print a warning and return a bool. Based on the returned bool value we either call some other function or even call sys.exit(). The following things should be changed:
- Rename methods: functions like _fit() should be renamed to indicate that it only checks something e.g. is_fit()
- Consider whether a validation class is even necessary, since all except for one of it's methods are static
- Throw proper, meaningful exceptions instead of calling sys.exit() if certain validation methods
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature of requestNew feature of requestin progressThis issue is being actively worked onThis issue is being actively worked on