Skip to content

Commit 7f476db

Browse files
authored
Merge pull request #3258 from verilog-to-routing/doc_typos
Minor typo fixes and clarifications to the documentation
2 parents 6732fca + fb7d635 commit 7f476db

14 files changed

+184
-207
lines changed

doc/src/.DS_Store

-6 KB
Binary file not shown.

doc/src/abc/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
ABC
44
===
55

6-
ABC is included with in VTR to perform technology independant logic optimization and technology mapping.
6+
ABC is included within VTR to perform technology independant logic optimization and technology mapping.
77

88
ABC is developed at UC Berkeley, see the `ABC homepage <http://www.eecs.berkeley.edu/~alanmi/abc/>`_ for details.

doc/src/arch/example_arch.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,12 @@
239239
<T_clock_to_Q max="7.732e-11" port="ff.Q" clock="clk"/>
240240
</pb_type>
241241
<interconnect>
242-
<!-- Two ff, make ff available to only corresponding luts -->
242+
<!-- Connect BLE input to LUT input and LUT output to FF in -->
243243
<direct name="direct1" input="ble.in" output="soft_logic.in"/>
244244
<direct name="direct2" input="soft_logic.out" output="ff.D"/>
245+
<!-- Connect BLE clock to FF clock -->
245246
<direct name="direct4" input="ble.clk" output="ff.clk"/>
247+
<!-- Connect the output of a MUX selecting between LUT output and FF output to the BLE output -->
246248
<mux name="mux1" input="ff.Q soft_logic.out" output="ble.out"/>
247249
</interconnect>
248250
</pb_type>

doc/src/arch/reference.rst

Lines changed: 75 additions & 78 deletions
Large diffs are not rendered by default.

doc/src/parmys/parmys_plugin.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ Available parameters
3333

3434
To enable mixing hard block and soft logic implementation of adders
3535

36-
.. option:: -vtr_prim
37-
38-
No additional passes will be executed.
39-
4036
.. option:: -vtr_prim
4137

4238
loads vtr primitives as modules, if the design uses vtr primitives then this flag is mandatory for first run

doc/src/vpr/command_line_usage.rst

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -877,8 +877,6 @@ If any of init_t, exit_t or alpha_t is specified, the user schedule, with a fixe
877877

878878
This place location file is in the same format as a :ref:`.place file <vpr_place_file>`, but does not require the first two lines which are normally at the top of a placement file that specify the netlist file, netlist ID, and array size.
879879

880-
**Default:** ````.
881-
882880
.. option:: --place_algorithm {bounding_box | criticality_timing | slack_timing}
883881

884882
Controls the algorithm used by the placer.
@@ -1055,7 +1053,7 @@ The following options are only valid when the placement engine is in timing-driv
10551053
Controls how critical a connection is considered as a function of its slack, at the start of the anneal.
10561054

10571055
If this value is 0, all connections are considered equally critical.
1058-
If this value is large, connections with small slacks are considered much more critical than connections with small slacks.
1056+
If this value is large, connections with small slacks are considered much more critical than connections with large slacks.
10591057
As the anneal progresses, the exponent used in the criticality computation gradually changes from its starting value of td_place_exp_first to its final value of :option:`--td_place_exp_last`.
10601058

10611059
**Default:** ``1.0``
@@ -1072,7 +1070,7 @@ The following options are only valid when the placement engine is in timing-driv
10721070

10731071
Controls how the timing-driven placer estimates delays.
10741072

1075-
* ``simple`` The placement delay estimator is built from the router lookahead. This takes less CPU time to build and it and still as accurate as the ``delta` model.
1073+
* ``simple`` The placement delay estimator is built from the router lookahead. This takes less CPU time to build and it is still as accurate as the ``delta`` model.
10761074
* ``delta`` The router is used to profile delay from various locations in the grid for various differences in position.
10771075
* ``delta_override`` Like ``delta`` but also includes special overrides to ensure effects of direct connects between blocks are accounted for.
10781076
This is potentially more accurate but is more complex and depending on the architecture (e.g. number of direct connects) may increase place run-time.
@@ -1108,7 +1106,7 @@ The following options are only valid when the placement engine is in timing-driv
11081106

11091107
Specifies the scaling factor for cell setup times used by the placer.
11101108
This effectively controls whether the placer should try to achieve extra margin on setup paths.
1111-
For example a value of 1.1 corresponds to requesting 10%% setup margin.
1109+
For example a value of 1.1 corresponds to requesting 10% setup margin.
11121110

11131111
**Default:** ``1.0``
11141112

@@ -1142,7 +1140,7 @@ The following options are only used when FPGA device and netlist contain a NoC r
11421140

11431141
XML file containing the list of traffic flows within the NoC (communication between routers).
11441142

1145-
.. note:: noc_flows_file are required to specify if NoC optimization is turned on (--noc on).
1143+
.. note:: It is required to specify a ``noc_flows_file`` if NoC optimization is turned on (``--noc on``).
11461144

11471145
.. option:: --noc_routing_algorithm {xy_routing | bfs_routing | west_first_routing | north_last_routing | negative_first_routing | odd_even_routing}
11481146

@@ -1872,14 +1870,14 @@ The following options are only valid when the router is in timing-driven mode (t
18721870

18731871
**Default:** ``off``
18741872

1875-
.. option:: --congested_routing_iteration_threshold CONGESTED_ROUTING_ITERATION_THRESHOLD
1873+
.. option:: --congested_routing_iteration_threshold <float>
18761874

18771875
Controls when the router enters a high effort mode to resolve lingering routing congestion.
18781876
Value is the fraction of max_router_iterations beyond which the routing is deemed congested.
18791877

18801878
**Default:** ``1.0`` (never)
18811879

1882-
.. option:: --route_bb_update {static, dynamic}
1880+
.. option:: --route_bb_update {static | dynamic}
18831881

18841882
Controls how the router's net bounding boxes are updated:
18851883

@@ -1888,14 +1886,14 @@ The following options are only valid when the router is in timing-driven mode (t
18881886

18891887
**Default:** ``dynamic``
18901888

1891-
.. option:: --router_high_fanout_threshold ROUTER_HIGH_FANOUT_THRESHOLD
1889+
.. option:: --router_high_fanout_threshold <int>
18921890

18931891
Specifies the net fanout beyond which a net is considered high fanout.
18941892
Values less than zero disable special behaviour for high fanout nets.
18951893

18961894
**Default:** ``64``
18971895

1898-
.. option:: --router_lookahead {classic, map}
1896+
.. option:: --router_lookahead {classic | map | compressed_map | extended_map | simple}
18991897

19001898
Controls what lookahead the router uses to calculate cost of completing a connection.
19011899

@@ -1980,7 +1978,7 @@ The following options are only valid when the router is in timing-driven mode (t
19801978

19811979
**Default:** ``-2``
19821980

1983-
.. option:: --router_debug_sink_rr ROUTER_DEBUG_SINK_RR
1981+
.. option:: --router_debug_sink_rr <int>
19841982

19851983
.. note:: This option is likely only of interest to developers debugging the routing algorithm
19861984

@@ -2290,7 +2288,7 @@ Analysis Options
22902288
22912289
It is possible that by opening a switch between (1,2) to (1,1), CHANY:2113 actually only extends from (1,3) to (1,2).
22922290

2293-
1. The preceding channel's ending coordinates have no relation to the following channel's starting coordinates.
2291+
2. The preceding channel's ending coordinates have no relation to the following channel's starting coordinates.
22942292
There is no logical contradiction, but for clarification, it is best to see an explanation of the VPR coordinate system.
22952293
The path can also be visualized by VPR graphics, as an illustration of this point:
22962294

@@ -2302,17 +2300,17 @@ Analysis Options
23022300

23032301
:numref:`fig_path_2` shows the routing resources used in Path #2 and their locations on the FPGA.
23042302

2305-
1. The signal emerges from near the top-right corner of the block to_FFC (OPIN:1479) and joins the topmost horizontal segment of length 1 (CHANX:2073).
2303+
3. The signal emerges from near the top-right corner of the block to_FFC (OPIN:1479) and joins the topmost horizontal segment of length 1 (CHANX:2073).
23062304

2307-
2. The signal proceeds to the left, then connects to the outermost, blue vertical segment of length 0 (CHANY:2139).
2305+
4. The signal proceeds to the left, then connects to the outermost, blue vertical segment of length 0 (CHANY:2139).
23082306

2309-
3. The signal continues downward and attaches to the horizontal segment of length 1 (CHANX:2040).
2307+
5. The signal continues downward and attaches to the horizontal segment of length 1 (CHANX:2040).
23102308

2311-
4. Of the aforementioned horizontal segment, after travelling one linear unit to the right, the signal jumps on a vertical segment of length 0 (CHANY:2166).
2309+
6. Of the aforementioned horizontal segment, after travelling one linear unit to the right, the signal jumps on a vertical segment of length 0 (CHANY:2166).
23122310

2313-
5. The signal travels upward and promptly connects to a horizontal segment of length 0 (CHANX:2076).
2311+
7. The signal travels upward and promptly connects to a horizontal segment of length 0 (CHANX:2076).
23142312

2315-
6. This segment connects to the green destination io (3,4).
2313+
8. This segment connects to the green destination io (3,4).
23162314

23172315
* ``debug``: Like ``detailed``, but includes additional VPR internal debug information such as timing graph node IDs (``tnode``) and routing SOURCE/SINK nodes.
23182316

doc/src/vpr/debug_aids.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ To access detailed echo files from VPR’s operation, use the command-line optio
1111
After parsing the netlist and architecture files, VPR dumps out an image of its internal data structures into echo files (typically ending in ``.echo``).
1212
These files can be examined to be sure that VPR is parsing the input files as you expect.
1313

14-
You ca visualize and control the placement move generator whenever the placement engine is paused in the UI. Run with graphics and VTR_ENABLE_DEBUG_LOGGONG enabled and set a breakpoint to stop placement. The new location of the moving block for each proposed move will be highlighted with GREEN and the old location will be highlighted with GOLD. The fanin and fanout blocks will also be highlighted. The move type, move outcome and delta cost will be printed in the status bar.
14+
You can visualize and control the placement move generator whenever the placement engine is paused in the UI. Run with graphics and VTR_ENABLE_DEBUG_LOGGING enabled and set a breakpoint to stop placement. The new location of the moving block for each proposed move will be highlighted with GREEN and the old location will be highlighted with GOLD. The fanin and fanout blocks will also be highlighted. The move type, move outcome and delta cost will be printed in the status bar.
15+
1516
.. warning:: VPR must have been compiled with `VTR_ENABLE_DEBUG_LOGGING` on to get any debug output from this flag.
1617

1718
If the preprocessor flag ``DEBUG`` is defined in ``vpr_types.h``, some additional sanity checks are performed during a run.

doc/src/vpr/file_formats.rst

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ Consider the following:
304304
305305
.latch g h re clk 0
306306
307-
The ``.names``' pin names are:
307+
The ``.names`` pin names are:
308308

309309
- ``f.in[0]`` (driven by net ``a``)
310310
- ``f.in[1]`` (driven by net ``b``)
@@ -1074,7 +1074,7 @@ An example of what a generated routing resource graph file would look like is sh
10741074
<y_list index="2" info="5"/>
10751075
</channels>
10761076
<switches>
1077-
<switch id="0" name="my_switch" buffered="1">
1077+
<switch id="0" name="my_switch" type="mux">
10781078
<timing R="100" Cin="1233-12" Cout="123e-12" Tdel="1e-9"/>
10791079
<sizing mux_trans_size="2.32" buf_size="23.54"/>
10801080
</switch>
@@ -1086,24 +1086,24 @@ An example of what a generated routing resource graph file would look like is sh
10861086
</segments>
10871087
<block_types>
10881088
<block_type id="0" name="io" width="1" height="1">
1089-
<pin_class type="input">
1089+
<pin_class type="INPUT">
10901090
<pin ptc="0">DATIN[0]</pin>
10911091
<pin ptc="1">DATIN[1]</pin>
10921092
<pin ptc="2">DATIN[2]</pin>
10931093
<pin ptc="3">DATIN[3]</pin>
10941094
</pin_class>
1095-
<pin_class type="output">
1095+
<pin_class type="OUTPUT">
10961096
<pin ptc="4">DATOUT[0]</pin>
10971097
<pin ptc="5">DATOUT[1]</pin>
10981098
<pin ptc="6">DATOUT[2]</pin>
10991099
<pin ptc="7">DATOUT[3]</pin>
11001100
</pin_class>
11011101
</block_type>
11021102
<block_type id="1" name="buf" width="1" height="1">
1103-
<pin_class type="input">
1103+
<pin_class type="INPUT">
11041104
<pin ptc="0">IN</pin>
11051105
</pin_class>
1106-
<pin_class type="output">
1106+
<pin_class type="OUTPUT">
11071107
<pin ptc="1">OUT</pin>
11081108
</pin_class>
11091109
</block_type>
@@ -1190,7 +1190,7 @@ Single Flow
11901190
A given traffic flow information is contained within the ``single_flow`` tag. There can be 0 or more single flow tags.
11911191
0 would indicate that an application does not have any traffic flows.
11921192

1193-
.. rrgraph:tag:: <channel src="logical_router_name" dst="logical_router_name" bandwidth="float" latency_cons="float" priority="int"/>
1193+
.. rrgraph:tag:: <single_flow src="logical_router_name" dst="logical_router_name" bandwidth="float" latency_cons="float" priority="int"/>
11941194
11951195
:opt_param latency_cons:
11961196
A floating point number which indicates the upper bound
@@ -1206,28 +1206,28 @@ A given traffic flow information is contained within the ``single_flow`` tag. Th
12061206

12071207
:req_param src:
12081208
A string which represents a logical router name in an application.
1209-
This logical router is the source endpoint for the traffic flow being described by the cor-
1210-
responding single flow tag. The logical router name must match the name of the router
1209+
This logical router is the source endpoint for the traffic flow being described by the corresponding
1210+
single flow tag. The logical router name must match the name of the router
12111211
as found in the clustered netlist; since this name assigned by the CAD tool, instead of
12121212
having the designer go through the clustered netlist to retrieve the exact name we instead
12131213
allow designers to use regex patters in the logical router name. For example, instead of
1214-
noc_router_adapter_block:noc_router_layer1_mvm2:slave_tready_reg0 user could pro-
1215-
vide ”.*noc_router_layer1_mvm2.*. This allows users to provide the instance name for a given logical router
1214+
``noc_router_adapter_block:noc_router_layer1_mvm2:slave_tready_reg0`` user could provide
1215+
``.*noc_router_layer1_mvm2.*``. This allows users to provide the instance name for a given logical router
12161216
module in the design. This is a required attribute.
12171217

12181218
:req_param dst:
12191219
A string which represents a logical router name in an application.
1220-
This logical router is the deastination endpoint for the traffic flow being described by the cor-
1221-
responding single flow tag. The logical router name must match the name of the router
1220+
This logical router is the deastination endpoint for the traffic flow being described by the corresponding
1221+
single flow tag. The logical router name must match the name of the router
12221222
as found in the clustered netlist; since this name assigned by the CAD tool, instead of
12231223
having the designer go through the clustered netlist to retrieve the exact name we instead
12241224
allow designers to use regex patters in the logical router name. For example, instead of
1225-
noc_router_adapter_block:noc_router_layer1_mvm3:slave_tready_reg0 user could pro-
1226-
vide ”.*noc_router_layer1_mvm3.*. This allows users to provide the instance name for a given logical router
1225+
``noc_router_adapter_block:noc_router_layer1_mvm3:slave_tready_reg0`` user could provide
1226+
``.*noc_router_layer1_mvm3.*``. This allows users to provide the instance name for a given logical router
12271227
module in the design. This is a required attribute.
12281228

12291229
:req_param bandwidth:
1230-
A floating point number which indicates the data size in the
1230+
A floating point number which indicates the data bandwidth in the
12311231
traffic flow communication. This is in units of bits-per-second (bps) and is a required
12321232
attribute.
12331233

@@ -1253,9 +1253,9 @@ Block types usage summary (.txt .xml or .json)
12531253
Block types usage summary is a file written in human or machine readable format.
12541254
It describes types and the amount of cluster-level FPGA resources that are used
12551255
by implemented design. This file is generated after the placement step with
1256-
option: `--write_block_usage <filename>`. It can be saved as a human readable
1256+
option: ``--write_block_usage <filename>``. It can be saved as a human readable
12571257
text file or in XML or JSON file to provide machine readable output. Format is
1258-
selected based on the extension of the `<filename>`.
1258+
selected based on the extension of the ``<filename>``.
12591259

12601260
The summary consists of 4 parameters:
12611261

0 commit comments

Comments
 (0)