You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for accepting my previous suggestions to this repository.
As you might have seen already, I applied multiple changes to my fork of your repository, which I think will improve the ease of use of the plugin for other users.
A short recap of what I did there:
removed all third party modules which are available with luarocks, and added a setup script for Linux and Windows which is using luarocks to install all dependencies (that might also solve the concerns you wrote about in your comment in Folders cjson, jsonschema and net removed unintentionally? #1)
replaced multiple dissectors for different protocols with a single dissector that dissects exactly that version of the protocol which is negotiated in the websocket handshake (I personally see no use to dissect e.g. a version 2.0 packet as a version 1.6 packet or vice versa)
changed the hardcoded path to the jsonschemes to a preference that can be changed in the Wireshark UI
let the plugin resolve the Action name by keeping track of the messageIds
changed the dissection process to have different functions to handle CALL, CALLRESULT, CALLERROR and newly added in 2.1 CALLRESULTERROR and SEND messages
minor bug fixes
Do you think it would be a benefit for this repository to also apply these changes here?
Last but not least, have you thought about adding an appropriate license to this repository, to clarify usage and contributions to this repository outside of the GitHub terms of use?
First of all, thank you for accepting my previous suggestions to this repository.
As you might have seen already, I applied multiple changes to my fork of your repository, which I think will improve the ease of use of the plugin for other users.
A short recap of what I did there:
Do you think it would be a benefit for this repository to also apply these changes here?
Last but not least, have you thought about adding an appropriate license to this repository, to clarify usage and contributions to this repository outside of the GitHub terms of use?
Regards,
Michael