-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Description
Currently kiss_fft headers are installed, thats not as trivial to change as some classes use kiss_fft_cpx and kiss_fftr_cfg types in their class private members, so without the kiss_fft headers the public headers for these classes would cause errors when included by API users.
The classes are:
- AmbisonicBinauralizer
- AmbisonicShelfFilters
- Decorrelator
The most trivial way to solve this seems to be the PIMPL idiom, see https://en.cppreference.com/w/cpp/language/pimpl.html
It would also mean that adding or removing private members would no longer break ABI, making it a lot easier to maintain stable ABI in the future.
Metadata
Metadata
Assignees
Labels
No labels