@@ -24,7 +24,7 @@ def export_as_csv(self, request, queryset):
2424
2525 writer .writerow (field_names )
2626 for obj in queryset :
27- row = writer .writerow ([getattr (obj , field ) for field in field_names ])
27+ writer .writerow ([getattr (obj , field ) for field in field_names ])
2828
2929 return response
3030
@@ -39,7 +39,7 @@ class SlowAPIsFilter(admin.SimpleListFilter):
3939 def __init__ (self , request , params , model , model_admin ):
4040 super ().__init__ (request , params , model , model_admin )
4141 if hasattr (settings , 'DRF_API_LOGGER_SLOW_API_ABOVE' ):
42- if type (settings .DRF_API_LOGGER_SLOW_API_ABOVE ) == int : # Making sure for integer value.
42+ if isinstance (settings .DRF_API_LOGGER_SLOW_API_ABOVE , int ) : # Making sure for integer value.
4343 self ._DRF_API_LOGGER_SLOW_API_ABOVE = settings .DRF_API_LOGGER_SLOW_API_ABOVE / 1000 # Converting to seconds.
4444
4545 def lookups (self , request , model_admin ):
@@ -83,10 +83,10 @@ def __init__(self, model, admin_site):
8383 super ().__init__ (model , admin_site )
8484 self ._DRF_API_LOGGER_TIMEDELTA = 0
8585 if hasattr (settings , 'DRF_API_LOGGER_SLOW_API_ABOVE' ):
86- if type (settings .DRF_API_LOGGER_SLOW_API_ABOVE ) == int : # Making sure for integer value.
86+ if isinstance (settings .DRF_API_LOGGER_SLOW_API_ABOVE , int ) : # Making sure for integer value.
8787 self .list_filter += (SlowAPIsFilter ,)
8888 if hasattr (settings , 'DRF_API_LOGGER_TIMEDELTA' ):
89- if type (settings .DRF_API_LOGGER_TIMEDELTA ) == int : # Making sure for integer value.
89+ if isinstance (settings .DRF_API_LOGGER_TIMEDELTA , int ) : # Making sure for integer value.
9090 self ._DRF_API_LOGGER_TIMEDELTA = settings .DRF_API_LOGGER_TIMEDELTA
9191
9292 def added_on_time (self , obj ):
@@ -113,7 +113,7 @@ def changelist_view(self, request, extra_context=None):
113113 response = super (APILogsAdmin , self ).changelist_view (request , extra_context )
114114 try :
115115 filtered_query_set = response .context_data ["cl" ].queryset
116- except :
116+ except Exception :
117117 return response
118118 analytics_model = filtered_query_set .values ('added_on__date' ).annotate (total = Count ('id' )).order_by ('total' )
119119 status_code_count_mode = filtered_query_set .values ('id' ).values ('status_code' ).annotate (
0 commit comments