-
Notifications
You must be signed in to change notification settings - Fork 297
[test] add e2e test for qwen3 moe w4a16 #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary This test would ordinarily take too long so we only quantize the first 10 layers Signed-off-by: HDCharles <charlesdavidhernandez@gmail.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @HDCharles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new end-to-end regression test designed to validate the W4A16 grouped quantization scheme for the Qwen3-30B-A3B model. The test setup includes a specific configuration that limits the quantization process to the initial ten layers of the model, a strategic choice made to optimize test execution time without compromising the core validation objective. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new end-to-end test for Qwen3 MoE model with W4A16 quantization. The changes look good, but I've found a couple of issues. There's a typo in a directory name (WNA16 instead of W4A16) in the test configuration, which will cause the test to fail. Additionally, the regex used to ignore layers during quantization is not robust and will fail for models with 100 or more layers. I've provided suggestions to fix both issues.
tests/e2e/vLLM/recipes/WNA16/recipe_w4a16_group_quant_first_10_layers.yaml
Show resolved
Hide resolved
Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
Signed-off-by: HDCharles <39544797+HDCharles@users.noreply.github.com>
Summary
This test would ordinarily take too long so we only quantize the first 10 layers
SUMMARY:
adding a new e2e test
blocked by vllm-project/vllm#28878 since we need to be able to run it in vllm as part of the test
TEST PLAN:
N/A