Skip to content

[benchmark] Make request IDs unique across clients by default #27723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

[benchmark] Make request IDs unique across clients by default #27723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c506ad7
Make request IDs unique
eicherseiji Oct 29, 2025
9032260
Verify request ID uniqueness in the scheduler
eicherseiji Oct 29, 2025
75c9136
Make --request-id-prefix default unique
eicherseiji Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/benchmarks/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import random
import shutil
import time
import uuid
import warnings
from collections.abc import AsyncGenerator, Iterable
from dataclasses import dataclass
Expand Down Expand Up @@ -1160,7 +1161,7 @@ def add_cli_args(parser: argparse.ArgumentParser):
"--request-id-prefix",
type=str,
required=False,
default="benchmark-serving",
default=f"bench-{uuid.uuid4().hex[:8]}-",
Copy link
Collaborator

@kouroshHakha kouroshHakha Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep this and simply add the uuid to the prefix?

So request_id will be

<prefix>-<uuid>-<cnt>

Copy link
Member

@markmc markmc Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean add the uuid in main() so that we will also add it to any user-supplied prefix?

Copy link
Collaborator

@kouroshHakha kouroshHakha Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Contributor Author

@eicherseiji eicherseiji Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kouroshHakha I'm not sure this works, because then users won't have full control over their prefix. I.e. a user must edit the code to get around us adding a uuid to their chosen prefix.

Copy link
Collaborator

@kouroshHakha kouroshHakha Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a hard limit on this pr obv. but I was thinking we would need to guarantee uniquness of the request-ids even if the end user wants to override the prefix. that way uuid is part of the auto appended suffix.

help="Specify the prefix of request id.",
)

Expand Down
Loading