[BugFix] Use unique ids for different transcription prompts #29372
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <nhill@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where multiple transcription prompts, potentially generated from chunking a single audio file, were assigned the same request ID. This could lead to issues with asynchronous request scheduling. The fix introduces unique request IDs for each prompt by appending an index, which is a correct and standard approach within this codebase. The change is straightforward and effectively resolves the issue.
DarkLight1337
approved these changes
Nov 25, 2025
bringlein
pushed a commit
to bringlein/vllm
that referenced
this pull request
Nov 26, 2025
…ject#29372) Signed-off-by: Nick Hill <nhill@redhat.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…ject#29372) Signed-off-by: Nick Hill <nhill@redhat.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…ject#29372) Signed-off-by: Nick Hill <nhill@redhat.com>
charlotte12l
pushed a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 5, 2025
…ject#29372) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Dec 6, 2025
…ject#29372) Signed-off-by: Nick Hill <nhill@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using duplicate ids back-to-back causes a problem with async scheduling, equivalent to the one described here #29355.