Fix RoPE failures in Transformers nightly #29700
Merged
+2
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the breaking changes related to RoPE configuration in Transformers v5. The removal of manual patching for transformers>=5.0.0 and the deletion of calls to the now-removed rope_config_validation function align with the library's new automatic handling of RoPE parameters. The changes are clean, well-targeted, and ensure compatibility with upcoming Transformers releases.
DarkLight1337
approved these changes
Nov 30, 2025
github-actions
bot
added
the
ready
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoPE config went through a secondary refactor in huggingface/transformers#42255 which:
standardize_rope_paramsandrope_config_validationPreTrainedConfigwhich does RoPE config patching and validation automaticallyTherefore, for Transformers v5 compatibility, this PR:
patch_rope_parametersas it's now handled insidePreTrainedConfig