[Misc] Update TokenizerLike interface and move get_cached_tokenizer
#29730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
requested review from
aarnphm,
chaunceyjiang and
hmellor
as code owners
DarkLight1337
added
the
ready
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Documentation preview: https://vllm--29730.org.readthedocs.build/en/29730/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tokenizer handling by updating the TokenizerLike interface, moving get_cached_tokenizer, and introducing HfTokenizer. The changes improve code structure and align tokenizer behavior with Hugging Face conventions. I've found a few issues related to type correctness in the protocol and a missing parameter in the MistralTokenizer implementation that should be addressed.
Isotr0py
approved these changes
Nov 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…r` (vllm-project#29730) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
amd-hhashemi
pushed a commit
to amd-hhashemi/vllm
that referenced
this pull request
Dec 2, 2025
…r` (vllm-project#29730) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
pad_token_idtoTokenizerLikeinterface to be used in Score API.__call__,encode,decodeandconvert_ids_to_tokens; apply them toMistralTokenizeras well. cc @patrickvonplatenfrom_pretrainedto be in line withTokenizerRegistry.get_tokenizer.get_cached_tokenizertovllm.tokenizers.hf(with back-compatibility)Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.