Skip to content

Fix AttributeError about _use_fi_prefill #29734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2025
Merged

Fix AttributeError about _use_fi_prefill #29734

merged 1 commit into from
Nov 30, 2025
+1 −1

Conversation

@hl475
Copy link
Contributor

@hl475 hl475 commented Nov 29, 2025 •
edited by github-actions bot
Loading

Purpose

After #28840 , the nightly Distributed Tests (H200) and Distributed Tests (B200) are failing due to

AttributeError: 'FlashAttnMLAImpl' object has no attribute '_use_fi_prefill'
AttributeError: 'CutlassMLAImpl' object has no attribute '_use_fi_prefill'

This PR provides a simple fix such that if no _use_fi_prefill and avoiding the runtime error.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@hl475
fix_attribute_error
933b438 
Signed-off-by: Huamin Li <3ericli@gmail.com>
@mergify mergify bot added the v1 label Nov 29, 2025
@hl475 hl475 marked this pull request as ready for review November 29, 2025 18:36
@hl475 hl475 requested a review from pavanimajety as a code owner November 29, 2025 18:36
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 29, 2025

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@hl475 hl475 mentioned this pull request Nov 29, 2025
Merged
5 tasks
@staugust
Copy link
Contributor

staugust commented Nov 30, 2025

LGTM, thank you very much.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 30, 2025 04:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 30, 2025
@DarkLight1337 DarkLight1337 merged commit 82c795d into vllm-project:main Nov 30, 2025
55 checks passed
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
@hl475 @kitaekatt
Fix AttributeError about _use_fi_prefill (vllm-project#29734)
0417e3f 
Signed-off-by: Huamin Li <3ericli@gmail.com>
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
@hl475 @amd-hhashemi
Fix AttributeError about _use_fi_prefill (vllm-project#29734)
ed31a75 
Signed-off-by: Huamin Li <3ericli@gmail.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@pavanimajety pavanimajety Awaiting requested review from pavanimajety pavanimajety is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hl475 @staugust @DarkLight1337