fix QF1001 rule from staticcheck

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Author: mmorel-35

.golangci.yaml

@@ -249,13 +249,12 @@ linters:
     staticcheck:
       checks:
         - all
-        - -QF1001 # FIXME
-        - -QF1003 # FIXME
-        - -QF1004 # FIXME
-        - -QF1007 # FIXME
-        - -QF1008 # FIXME
-        - -QF1009 # FIXME
-        - -QF1012 # FIXME
+        - -QF1003 # Convert if/else-if chain to tagged switch
+        - -QF1004 # Use strings.ReplaceAll instead of strings.Replace with n == -1
+        - -QF1007 # Merge conditional assignment into variable declaration
+        - -QF1008 # Omit embedded fields from selector expression
+        - -QF1009 # Use time.Time.Equal instead of == operator
+        - -QF1012 # Use fmt.Fprintf(x, ...) instead of x.Write(fmt.Sprintf(...))
 
     testifylint:
       # TODO: enable them all

pkg/controller/backup_sync_controller.go

@@ -353,7 +353,7 @@ func (b *backupSyncReconciler) deleteOrphanedBackups(ctx context.Context, locati
 
 	for i, backup := range backupList.Items {
 		log = log.WithField("backup", backup.Name)
-		if !(backup.Status.Phase == velerov1api.BackupPhaseCompleted || backup.Status.Phase == velerov1api.BackupPhasePartiallyFailed) || backupStoreBackups.Has(backup.Name) {
+		if !(backup.Status.Phase != velerov1api.BackupPhaseCompleted || backup.Status.Phase == velerov1api.BackupPhasePartiallyFailed) || backupStoreBackups.Has(backup.Name) {
 			continue
 		}
 

pkg/uploader/kopia/snapshot.go

@@ -314,7 +314,7 @@ func reportSnapshotStatus(manifest *snapshot.Manifest, policyTree *policy.Tree)
 				break
 			}
 			policy := policyTree.EffectivePolicy()
-			if !(policy != nil && bool(*policy.ErrorHandlingPolicy.IgnoreUnknownTypes) && strings.Contains(ent.Error, fs.ErrUnknown.Error())) {
+			if !(policy == nil || !bool(*policy.ErrorHandlingPolicy.IgnoreUnknownTypes) || !strings.Contains(ent.Error, fs.ErrUnknown.Error()) {
 				errs = append(errs, fmt.Sprintf("Error when processing %v: %v", ent.EntryPath, ent.Error))
 			}
 		}