Remove restore-wait initcontainer if not needed on restore

[kaovilai]

Please add a summary of your change

This PR fixes issue #8870 where Velero was unnecessarily adding the restore-wait init container when restoring pods with volumes that were backed up using native datamover or CSI.

When restoring pods with volumes, Velero was always adding the restore-wait init container, even when the volumes were backed up using native datamover or CSI and didn't need file system restores. This was causing unnecessary overhead and potential issues.

Solution

Modified the pod volume restore action to check if any volumes actually need file system restores before adding the init container:

1. Added a check in pkg/restore/actions/pod_volume_restore_action.go to determine if any volumes need file system restores by checking if there are matching PodVolumeBackups for the pod's volumes.
2. Only add the restore-wait init container if there are volumes that need file system restores.
3. Updated tests to match the new logic and renamed the test function to be more descriptive.

Testing

• Added test cases to verify that the init container is only added when needed
• Updated existing test cases to work with the new logic
• All tests are passing

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Does your change fix a particular issue?

Fixes #8870

Please indicate you've done the following:

• Accepted the DCO. Commits without the DCO will delay acceptance.
• Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
• Updated the corresponding documentation in site/content/docs/main.

[Copilot]

Pull Request Overview

This PR updates the pod volume restore action to conditionally add the restore-wait init container only when volumes actually need a file system restore. Key changes include:

• Adding a check in pkg/restore/actions/pod_volume_restore_action.go that iterates over volume snapshots and PodVolumeBackups to decide if an init container is necessary.
• Updating and expanding tests in pkg/restore/actions/pod_volume_restore_action_test.go to cover scenarios with and without file system restores.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/restore/actions/pod_volume_restore_action.go	Added logic to determine whether file system restoration is required before adding the init container.
pkg/restore/actions/pod_volume_restore_action_test.go	Updated tests and added new cases to verify the behavior of the file system restore check.

Files not reviewed (1)

• changelogs/unreleased/8880-kaovilai: Language not supported

Comments suppressed due to low confidence (1)

pkg/restore/actions/pod_volume_restore_action_test.go:545

• [nitpick] The test case name indicates that a matching pod volume backup should result in an init container, but the expected init container count is set to 0. Please update the test name or expected outcome to clearly reflect the intended behavior.

name: "matching pod volume backup results in init container",

[codecov]

Codecov Report

Attention: Patch coverage is 82.60870% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (d2c6b6b) to head (d2e9556).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/restore/actions/pod_volume_restore_action.go	82.60%	14 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8880      +/-   ##
==========================================
+ Coverage   59.70%   59.74%   +0.04%     
==========================================
  Files         370      370              
  Lines       40326    40353      +27     
==========================================
+ Hits        24075    24109      +34     
+ Misses      14770    14765       -5     
+ Partials     1481     1479       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blackpiglet]

We need to make some changes.
To me, the current implementation cannot fix the issue.
Please see my comments.

[kaovilai]

test passing, rebasing.