-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support for configuring VGS label key #8938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuring VGS label key #8938
Conversation
1b09af4
to
2644613
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8938 +/- ##
=======================================
Coverage 59.57% 59.57%
=======================================
Files 370 370
Lines 40278 40285 +7
=======================================
+ Hits 23995 24000 +5
- Misses 14780 14782 +2
Partials 1503 1503 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2644613
to
f9afea1
Compare
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog file Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
f9afea1
to
10859ae
Compare
Review request @Lyndon-Li @blackpiglet @sseago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acking this, although we may want to consider in a subsequent PR renaming the default from "velero.io/volume-group-snapshot" to "velero.io/volume-group" -- since the labeled PVCs constitute the volume group, not the snapshot.
Thank you for contributing to Velero!
Please add a summary of your change
--volume-group-snapshot-label-key
to allow users to override the default label key used for grouping PVCs into VolumeGroupSnapshots.spec.volumeGroupSnapshotLabelKey
to the Backup CRD to support per-backup customization.velero.io/volume-group-snapshot
if not specified via flag or spec.Does your change fix a particular issue?
Fixes #8934
Related to sub-task of #8865
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.