Skip to content

Add support for configuring VGS label key #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

shubham-pampattiwar
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

  • Introduces a new server flag --volume-group-snapshot-label-key to allow users to override the default label key used for grouping PVCs into VolumeGroupSnapshots.
  • Adds spec.volumeGroupSnapshotLabelKey to the Backup CRD to support per-backup customization.
  • Default label key is velero.io/volume-group-snapshot if not specified via flag or spec.
  • Adds unit tests.

Does your change fix a particular issue?

Fixes #8934

Related to sub-task of #8865

Please indicate you've done the following:

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.57%. Comparing base (4c23f66) to head (10859ae).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/server/server.go 0.00% 1 Missing ⚠️
pkg/controller/backup_controller.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8938   +/-   ##
=======================================
  Coverage   59.57%   59.57%           
=======================================
  Files         370      370           
  Lines       40278    40285    +7     
=======================================
+ Hits        23995    24000    +5     
- Misses      14780    14782    +2     
  Partials     1503     1503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
@shubham-pampattiwar
Copy link
Collaborator Author

Review request @Lyndon-Li @blackpiglet @sseago

Copy link
Collaborator

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acking this, although we may want to consider in a subsequent PR renaming the default from "velero.io/volume-group-snapshot" to "velero.io/volume-group" -- since the labeled PVCs constitute the volume group, not the snapshot.

@sseago sseago merged commit d2c6b6b into vmware-tanzu:main May 30, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept the label to be used for VGS from the user
4 participants