[DRAFT] Define boot options in vm spec #967
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
reviewed
May 9, 2025
There was a problem hiding this comment.
Hey @abaruni , I know it's a draft so I won't mark this as "Request changes," but there are a few places I left comments. FYI, the "kube API conventions" I reference in the feedback is located at https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md. I find it to be helpful.
api/v1alpha4/virtualmachine_types.go
Outdated
| type VirtualMachineBootOptionsBootableDevice string | ||
|
|
||
| const ( | ||
| VirtualMachineBootOptionsBootableDiskDevice VirtualMachineBootOptionsBootableDevice = "disk" |
There was a problem hiding this comment.
Kube API conventions wants enums to be CamelCased, ex. Disk, Network, CDRom.
api/v1alpha4/virtualmachine_types.go
Outdated
| type VirtualMachineBootOptionsNetworkBootProtocol string | ||
|
|
||
| const ( | ||
| VirtualMachineBootOptionsNetworkBootProtocolIPv4 VirtualMachineBootOptionsNetworkBootProtocol = "ipv4" |
There was a problem hiding this comment.
Should be IP4 and IP6 to be consistent with how we do not use the v in the other locations in our spec either.
api/v1alpha4/virtualmachine_types.go
Outdated
| // will refuse to start any images which do not pass those signature checks. | ||
| // | ||
| // Please note, this field will not be honored unless the value of spec.firmware | ||
| // is "efi". |
There was a problem hiding this comment.
On the comment, spec.firmware would be set to EFI as proper acronyms are capitalized for Kube enums.
github-actions
bot
added
size/L
abaruni
force-pushed
the
topic/ab002705/VMSVC-2627
branch
from
a75582f to
0f32832
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: