Skip to content

Deprecate resolveRenameNewName, resolveRenameEditText hooks #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnsoncodehk opened this issue May 9, 2024 · 1 comment
Closed

Deprecate resolveRenameNewName, resolveRenameEditText hooks #176

johnsoncodehk opened this issue May 9, 2024 · 1 comment

Comments

@johnsoncodehk
Copy link
Member

The findRenameLocations API of TS LanguageService does not support modifying rename text. For the functional consistency between TS plugin and LSP server, we should no longer use these hooks.
@johnsoncodehk johnsoncodehk mentioned this issue Aug 4, 2024
Merged
2 tasks
@KazariEX KazariEX mentioned this issue Aug 7, 2024
Closed
@johnsoncodehk
Copy link
Member Author

Temporarily reverted in 198085c to avoid causing breaking change. Will be reimplemented in v2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnsoncodehk