fix(typescript): force update target file version on association dirty #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for heads up! I should be able to remove my workaround now, right? |
johnsoncodehk
changed the title
|
@piotrtomiak I think yes! But of course we need to test it in WebStorm. (It has been tested in Glint) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Glint, when the association script (.hbs) is updated and the target script (.ts) is not, the association script's diagnostics don't refresh correctly because the target script's getScriptVersion value hasn't changed.
We can't proxy getScriptVersion to deal with this, that would cause serious performance issues with the tsserver some how, so we send a change event to the tsserver session to force the target script to be considered new.
/cc @piotrtomiak, @machty