[Bug]: examples/openclaw-plugin/index.ts missing withTimeout protection (same as #673)

[Meskjei]

Bug Description

PR #688 fixed the auto-recall timeout issue in examples/openclaw-memory-plugin/index.ts by wrapping the recall logic with withTimeout(). However, the plugin code was later moved to examples/openclaw-plugin/index.ts, and the fix was not synchronized to the new location.

The current code in examples/openclaw-plugin/index.ts (main branch) still has the same bug:

• autoRecallTimeoutMs = 5_000 is defined but never used
• withTimeout is imported but not called in the auto-recall path
• If the OpenViking HTTP calls hang (e.g., during transient connection issues), the before_prompt_build hook blocks indefinitely, causing total agent silence

Steps to Reproduce

1. Use the plugin from examples/openclaw-plugin/ directory
2. Configure with autoRecall: true
3. Have OpenViking server in a transient state (e.g., shortly after gateway restart)
4. Send a message to the agent
5. Agent hangs silently at before_prompt_build hook

Expected Behavior

If auto-recall does not complete within autoRecallTimeoutMs (5 seconds), the hook should:

• Time out gracefully
• Log a warning
• Allow the agent to start without memory context

Actual Behavior

The hook blocks indefinitely. No response is ever sent to the user.

Root Cause

PR #688 applied the fix to examples/openclaw-memory-plugin/index.ts, but the plugin was later refactored/moved to examples/openclaw-plugin/index.ts without carrying over the timeout protection.

Proposed Fix

Apply the same fix from PR #688 to examples/openclaw-plugin/index.ts:

// Current code (line ~439):
if (cfg.autoRecall && queryText.length >= 5) {
  const precheck = await quickRecallPrecheck(...);
  if (!precheck.ok) {
    // skip
  } else {
    try {
      // ← No timeout protection here
      const candidateLimit = ...
      const [userSettled, agentSettled] = await Promise.allSettled([...]);
      // ... more awaits
    } catch (err) {
      api.logger.warn(...);
    }
  }
}

// Should be:
if (cfg.autoRecall && queryText.length >= 5) {
  const precheck = await quickRecallPrecheck(...);
  if (!precheck.ok) {
    // skip
  } else {
    try {
      await withTimeout(
        (async () => {
          // ← Wrap entire recall logic in IIFE
          const candidateLimit = ...
          const [userSettled, agentSettled] = await Promise.allSettled([...]);
          // ... more awaits
        })(),
        autoRecallTimeoutMs,
        `openviking: auto-recall timed out after ${autoRecallTimeoutMs}ms`,
      );
    } catch (err) {
      api.logger.warn(`openviking: auto-recall failed or timed out: ${String(err)}`);
    }
  }
}

Additional Context

• This is the same bug as [Bug]: memory-openviking plugin before_agent_start auto-recall hangs indefinitely, causing total silent agent failure #673, but affecting the refactored plugin directory
• Impact: Critical — any transient connection issue causes complete, permanent agent silence
• Workaround: Set autoRecall: false in plugin config

[qin-ptr]

Thanks for reporting this! You're absolutely right.

Verification

I've confirmed the issue exists on the current main branch:

1. Missing import: withTimeout is not imported from process-manager.ts (though it's available at line 32 of that file)
2. Missing timeout protection: The auto-recall logic at index.ts:433-479 has no withTimeout wrapper around the Promise.allSettled calls and subsequent memory processing
3. Root cause confirmed: PR fix(plugin): wrap auto-recall in withTimeout to prevent indefinite agent hang #688 fixed this exact issue in examples/openclaw-memory-plugin/index.ts, but when the plugin was refactored to examples/openclaw-plugin/, the fix wasn't carried over

Status

Good news: PR #752 has already been submitted and correctly fixes this issue. The fix follows the same pattern as PR #688:

• Imports withTimeout from process-manager.ts
• Defines autoRecallTimeoutMs = 5_000
• Wraps the entire auto-recall block in withTimeout() using an IIFE

Additionally, PR #749 addresses a related (but distinct) timeout issue with the getClient() call in the same hook.

Both PRs are currently open and awaiting review. Once merged, the indefinite blocking behavior will be resolved.

Impact

As you correctly noted, this is critical — any transient connection issue during auto-recall causes complete, permanent agent silence without user-facing errors.

🤖 I am a bot owned by @qin-ctx.