From 604ba7b77fec90826f37b7b678dc5aefc58f64f3 Mon Sep 17 00:00:00 2001 From: qin-ctx Date: Thu, 5 Mar 2026 18:03:23 +0800 Subject: [PATCH 1/2] ci: enhance PR review with severity classification and review checklist Co-Authored-By: Claude Opus 4.6 --- .github/workflows/pr-review.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/pr-review.yml b/.github/workflows/pr-review.yml index 06586855..3ad88857 100644 --- a/.github/workflows/pr-review.yml +++ b/.github/workflows/pr-review.yml @@ -25,3 +25,18 @@ jobs: github_action_config.auto_review: "true" github_action_config.auto_describe: "false" github_action_config.auto_improve: "true" + pr_reviewer.num_code_suggestions: "4" + pr_reviewer.extra_instructions: > + Classify each finding with a severity tag: + [Bug] = Must fix: behavioral regression, logic error, security vulnerability, data loss/corruption, resource leak, API contract violation. + [Suggestion] = Recommended: missing tests, dead code, inconsistency, poor observability, unclear intent, unrelated changes, performance issues (N+1 queries, redundant computation in loops, unnecessary large object copies, unbounded collection growth). + + Review focus areas: + 1. Control Flow - are all branches reachable? errors propagated correctly? unintended fall-through? + 2. Data Flow - input validated at boundaries? implicit type coercion? null/empty handled? + 3. Integration Points - API changes backward compatible? config defaults sensible? dependencies pinned? + 4. Concurrency - shared state synchronized? execution order assumptions valid? cleanup in all paths? + + Be specific: reference exact variable names, function calls, conditions. + When suggesting a fix, include a code block with the recommended change. + Match the language of the PR (Chinese PR = Chinese comments, English PR = English comments). From 2aba685b98e518853db7d37f0464d16511d32dde Mon Sep 17 00:00:00 2001 From: qin-ctx Date: Thu, 5 Mar 2026 19:03:00 +0800 Subject: [PATCH 2/2] ci: remove unused num_code_suggestions from pr_reviewer config Co-Authored-By: Claude Opus 4.6 --- .github/workflows/pr-review.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pr-review.yml b/.github/workflows/pr-review.yml index 3ad88857..2b42ab27 100644 --- a/.github/workflows/pr-review.yml +++ b/.github/workflows/pr-review.yml @@ -25,7 +25,6 @@ jobs: github_action_config.auto_review: "true" github_action_config.auto_describe: "false" github_action_config.auto_improve: "true" - pr_reviewer.num_code_suggestions: "4" pr_reviewer.extra_instructions: > Classify each finding with a severity tag: [Bug] = Must fix: behavioral regression, logic error, security vulnerability, data loss/corruption, resource leak, API contract violation.