Prefer 'installed' to 'present' for packages

Align with Puppet default value for the `ensure` parameter of package
resources.

Author: smortex

manifests/client.pp

@@ -4,7 +4,7 @@
   Stdlib::Absolutepath                          $file,
 
   # Options
-  String[1]                                     $package_version               = present,
+  String[1]                                     $package_version               = installed,
   Optional[String[1]]                           $base                          = undef,
   Optional[String[1]]                           $bind_policy                   = undef,
   Optional[String[1]]                           $bind_timelimit                = undef,

manifests/server.pp

@@ -13,7 +13,7 @@
   Array[String[1]] $ldapi_ifs,
   Stdlib::Absolutepath $default_directory,
   Boolean $manage_epel                              = true,
-  String[1] $package_version                        = present,
+  String[1] $package_version                        = installed,
   Optional[Boolean] $enable_chown                   = undef,
   Optional[Boolean] $service_hasstatus              = undef,
   Boolean $enable                                   = true,

manifests/utils.pp

@@ -1,7 +1,7 @@
 # See README.md for details.
 class openldap::utils (
   Optional[String[1]] $package         = undef,
-  String[1]           $package_version = present,
+  String[1]           $package_version = installed,
 ) {
   if $package {
     package { $package:

spec/classes/openldap_client_install_spec.rb

@@ -22,16 +22,16 @@
           case facts[:os]['release']['major']
           when '22.04'
             it {
-              is_expected.to contain_package('libldap-2.5-0').with(ensure: :present)
+              is_expected.to contain_package('libldap-2.5-0').with(ensure: :installed)
             }
           else
             it {
-              is_expected.to contain_package('libldap-2.4-2').with(ensure: :present)
+              is_expected.to contain_package('libldap-2.4-2').with(ensure: :installed)
             }
           end
         when 'RedHat'
           it {
-            is_expected.to contain_package('openldap').with(ensure: :present)
+            is_expected.to contain_package('openldap').with(ensure: :installed)
           }
         end
       end
@@ -45,7 +45,7 @@
         it { is_expected.to contain_class('openldap::client::install') }
 
         it {
-          is_expected.to contain_package('foo').with(ensure: :present)
+          is_expected.to contain_package('foo').with(ensure: :installed)
         }
       end
 

spec/classes/openldap_server_install_spec.rb

@@ -16,11 +16,11 @@
         case facts[:osfamily]
         when 'Debian'
           it {
-            is_expected.to contain_package('slapd').with(ensure: :present)
+            is_expected.to contain_package('slapd').with(ensure: :installed)
           }
         when 'RedHat'
           it {
-            is_expected.to contain_package('openldap-servers').with(ensure: :present)
+            is_expected.to contain_package('openldap-servers').with(ensure: :installed)
           }
         end
 
@@ -48,7 +48,7 @@
         it { is_expected.to contain_class('openldap::server::install') }
 
         it {
-          is_expected.to contain_package('foo').with(ensure: :present)
+          is_expected.to contain_package('foo').with(ensure: :installed)
         }
       end
 

spec/classes/openldap_utils_spec.rb

@@ -15,11 +15,11 @@
         case facts[:osfamily]
         when 'Debian'
           it {
-            is_expected.to contain_package('ldap-utils').with(ensure: :present)
+            is_expected.to contain_package('ldap-utils').with(ensure: :installed)
           }
         when 'RedHat'
           it {
-            is_expected.to contain_package('openldap-clients').with(ensure: :present)
+            is_expected.to contain_package('openldap-clients').with(ensure: :installed)
           }
         end
       end
@@ -32,7 +32,7 @@
         it { is_expected.to compile.with_all_deps }
 
         it {
-          is_expected.to contain_package('foo').with(ensure: :present)
+          is_expected.to contain_package('foo').with(ensure: :installed)
         }
       end