refactor(lint): fix lint in tests

Author: posva

examples/index.html

@@ -66,7 +66,7 @@
           newTodoText: ''
         },
         firestore: {
-          todos,
+          todos: todos.where('finished', '==', false),
           config
         },
         methods: {

package.json

@@ -12,7 +12,7 @@
     "README.md"
   ],
   "scripts": {
-    "lint": "eslint --ext=js,html src tests examples",
+    "lint": "eslint --ext=js,html src test examples",
     "build": "node build/build.js",
     "pretest": "npm run lint",
     "test": "npm run unit",

test/bind.spec.js

@@ -1,8 +1,5 @@
 import test from 'ava'
 import Vuefire from '../src'
-import {
-  createSnapshot
-} from '../src/utils'
 import {
   db,
   tick,
@@ -24,8 +21,8 @@ test.beforeEach(async t => {
     // but it's a good practice to set it to an empty array
     data: () => ({
       items: null,
-      item: null,
-    }),
+      item: null
+    })
   }).$mount()
   await tick()
 })

test/collection.spec.js

@@ -1,9 +1,6 @@
 import test from 'ava'
 import sinon from 'sinon'
 import Vuefire from '../src'
-import {
-  createSnapshot
-} from '../src/utils'
 import {
   db,
   tick,

test/document.spec.js

@@ -1,8 +1,5 @@
 import test from 'ava'
 import Vuefire from '../src'
-import {
-  createSnapshot
-} from '../src/utils'
 import {
   db,
   tick,
@@ -24,7 +21,7 @@ test.beforeEach(async t => {
     // but it's a good practice to set it to an empty array
     data: () => ({
       items: null,
-      item: null,
+      item: null
     }),
     firestore: {
       items: t.context.collection,

test/helpers/mock.js

@@ -1,8 +1,8 @@
 export class DocumentSnapshot {
   constructor (firestore, key, document) {
-    this._firestore = firestore;
-    this._key = key;
-    this._document = document;
+    this._firestore = firestore
+    this._key = key
+    this._document = document
   }
 
   data () {
@@ -41,10 +41,11 @@ class DocumentReference {
   onSnapshot (cb, onError) {
     this.cb = cb
     this.onError = onError
-    return () => this.cb = this.onError = noop
+    return () => {
+      this.cb = this.onError = noop
+    }
   }
 
-
   async delete () {
     return this.collection._remove(this.id)
   }
@@ -65,7 +66,9 @@ class CollectionReference {
   onSnapshot (cb, onError) {
     this.cb = cb
     this.onError = onError
-    return () => this.cb = this.onError = noop
+    return () => {
+      this.cb = this.onError = noop
+    }
   }
 
   async add (data) {
@@ -81,7 +84,7 @@ class CollectionReference {
         type: 'added',
         doc: new DocumentSnapshot(null, id, data),
         newIndex: Object.keys(this.data).length,
-        oldIndex: -1,
+        oldIndex: -1
       }]
     })
     return this.data[id]
@@ -92,12 +95,12 @@ class CollectionReference {
 
   doc (id) {
     id = id || new Key()
-    return this.data[id] = this.data[id] || new DocumentReference({
+    return (this.data[id] = this.data[id] || new DocumentReference({
       collection: this,
       id,
       data: {},
       index: Object.keys(this.data).length
-    })
+    }))
   }
 
   async _remove (id) {
@@ -106,7 +109,7 @@ class CollectionReference {
     this.cb({
       docChanges: [{
         doc: new DocumentSnapshot(null, id, ref.data),
-        type: 'removed',
+        type: 'removed'
       }]
     })
     ref.collection = null
@@ -119,10 +122,9 @@ class CollectionReference {
         type: 'modified',
         doc: new DocumentSnapshot(null, id, data),
         oldIndex: this.data[id].index,
-        newIndex: this.data[id].index,
+        newIndex: this.data[id].index
       }]
     })
-
   }
 }
 
@@ -133,6 +135,6 @@ export const db = {
   collection (name) {
     // create a collection if no name provided
     name = name || `random__${this.n++}`
-    return db[name] = db[name] || new CollectionReference()
+    return (db[name] = db[name] || new CollectionReference())
   }
 }

test/helpers/wait-for-update.js

@@ -1,57 +1,5 @@
 import Vue from 'vue'
 
-// Testing helper
-// nextTick().then(() => {
-//
-// Automatically waits for nextTick
-// }).then(() => {
-// return a promise or value to skip the wait
-// })
-function oldtick () {
-  const jobs = []
-  let done
-
-  const chainer = {
-    then (cb) {
-      jobs.push(cb)
-      return chainer
-    },
-  }
-
-  function shift (...args) {
-    const job = jobs.shift()
-    let result
-    try {
-      result = job(...args)
-    } catch (e) {
-      jobs.length = 0
-      done(e)
-    }
-
-    // wait for nextTick
-    if (result !== undefined) {
-      if (result.then) {
-        result.then(shift)
-      } else {
-        shift(result)
-      }
-    } else if (jobs.length) {
-      requestAnimationFrame(() => Vue.nextTick(shift))
-    }
-  }
-
-  // First time
-  Vue.nextTick(() => {
-    done = jobs[jobs.length - 1]
-    if (done && done.toString().slice(0, 14) !== 'function (err)') {
-      throw new Error('waitForUpdate chain is missing .then(done)')
-    }
-    shift()
-  })
-
-  return chainer
-}
-
 function tick () {
   return new Promise((resolve, reject) => {
     Vue.nextTick(resolve)
@@ -65,5 +13,5 @@ function delay (time) {
 export {
   tick,
   delay,
-  Vue,
+  Vue
 }

test/index.spec.js

@@ -1,8 +1,5 @@
 import test from 'ava'
 import Vuefire from '../src'
-import {
-  createSnapshot
-} from '../src/utils'
 import {
   db,
   tick,
@@ -24,7 +21,7 @@ test.beforeEach(async t => {
     // but it's a good practice to set it to an empty array
     data: () => ({
       items: null,
-      item: null,
+      item: null
     }),
     firestore: {
       items: t.context.collection,
@@ -36,8 +33,8 @@ test.beforeEach(async t => {
 
 test('does nothing with no firestore', t => {
   const vm = new Vue({
-    render: h => ('p', 'foo'),
-    data: () => ({ items: null }),
+    render: h => h('p', 'foo'),
+    data: () => ({ items: null })
   })
   t.deepEqual(vm.items, null)
 })
@@ -50,8 +47,8 @@ test('setups _firestoreUnbinds', t => {
 
 test('setups _firestoreUnbinds with no firestore options', t => {
   const vm = new Vue({
-    render: h => ('p', 'foo'),
-    data: () => ({ items: null }),
+    render: h => h('p', 'foo'),
+    data: () => ({ items: null })
   })
   t.truthy(vm._firestoreUnbinds)
   t.deepEqual(Object.keys(vm._firestoreUnbinds), [])

test/unbind.spec.js

@@ -1,9 +1,6 @@
 import test from 'ava'
 import sinon from 'sinon'
 import Vuefire from '../src'
-import {
-  createSnapshot
-} from '../src/utils'
 import {
   db,
   tick,
@@ -25,7 +22,7 @@ test.beforeEach(async t => {
     // but it's a good practice to set it to an empty array
     data: () => ({
       items: null,
-      item: null,
+      item: null
     }),
     firestore: {
       items: t.context.collection,

test/utils.spec.js

@@ -1,9 +1,8 @@
 import test from 'ava'
 import {
-  createSnapshot,
+  createSnapshot
 } from '../src/utils'
 import {
-  collection,
   Key,
   id,
   DocumentSnapshot