Skip to content

Conversation

@Promise2679
Copy link

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

When using custom storage backends, state changes cannot be synchronized across different documents.

Here is a simple example. If you open two tabs and click the button in tab A, tab B will not update the value instantly.

As mentioned in notes, I solved this by using a BroadcastChannel object to send and receive data.

Additional context

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 30, 2025
Copy link
Member

@9romise 9romise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content added in this PR goes outside the responsibility of useStorage.
We also provide useBroadcastChannel, so your use case can be achieved by using useStorage and useBroadcastChannel together.

@Promise2679
Copy link
Author

Promise2679 commented Nov 30, 2025

I think the content added in this PR goes outside the responsibility of useStorage. We also provide useBroadcastChannel, so your use case can be achieved by using useStorage and useBroadcastChannel together.

I think since useStorage supports cross-document sync for localStorage (although it is handled by the browser), it should also offer the same capability when using customStorage, rather than a more complicated approach just because a custom storage is used.

Anyway, I am just following the TODO's instruction, I'll respect your final decision.

@9romise
Copy link
Member

9romise commented Nov 30, 2025

Anyway, I am just following the TODO's instruction, I'll respect your final decision.

Oh, I see. In this case, would it be possible to use useBroadcastChannel directly instead of implementing it manually?

@Promise2679
Copy link
Author

yeah I'll have a try

@Promise2679
Copy link
Author

useBroadcastChannel internally listens to the message event, but it doesn't offer a custom callback, so I use a watcher to call the update function.

I'm wondering whether it would make sense to add an onMessage option to useBroadcastChannel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants