Merge pull request #9 from wavesoftware/bugfix/7-proper-inheritance-and-stacktrace

Fix #7: Proper handling for IE (tested on ie11), Edge, Firefox, Chrome and NodeJS

Author: cardil

dist/browser/index.html

@@ -11,7 +11,7 @@
       @import url(https://fonts.googleapis.com/css?family=PT+Sans|Source+Code+Pro);
       body {
         font-family: 'PT Sans', sans-serif;
-        font-size: 1.3em;
+        font-size: 1em;
         padding: 1em;
       }
       pre, code {
@@ -65,7 +65,7 @@ <h3>Code:</h3>
       log.error(e.stack);
       if (e instanceof EidRuntimeException) {
         // or better save your exceptions!
-        logGateway.put(e, {eid: e.eid});
+        logGateway.put(e, inspectable({eid: e.eid}));
       }
     }
     </code></pre>
@@ -96,9 +96,21 @@ <h3>Console:</h3>
         logentry('ERROR', message);
       }
     };
+    var inspectable = function(obj) {
+      obj.toString = function() {
+        var parts = [];
+        for (var k in obj) {
+          if (obj.hasOwnProperty(k) && k !== 'toString') {
+            parts.push(k.toString() + ': ' + obj[k].toString());
+          }
+        }
+        return '{ ' + parts.join(', ') + ' }';
+      };
+      return obj;
+    };
     var logGateway = {
       put: function(ex, extra) {
-        logentry('INFO', 'FakeLogz.io PUT an exception: `' + ex.toString() + '` with extra data of: `' + JSON.stringify(extra) + '`');
+        logentry('INFO', 'FakeLogz.io PUT exception: `' + ex.toString() + '`, payload: `' + extra.toString() + '`');
       }
     };
     var code = document.getElementById('code').textContent;

gulp/tests.js

@@ -44,8 +44,7 @@ module.exports = {
     var src = prependToAll('..', config.sources);
     var stream = gulp.src(testSrc, { read: false })
       .pipe(cover.instrument({
-        pattern: src,
-        debugDirectory: 'debug'
+        pattern: src
       }))
       .pipe(mocha())
       .pipe(cover.gather());

lib/eid/exceptions.js

@@ -37,10 +37,27 @@
     modern: function(target, constructor) {
       Error.captureStackTrace(target, constructor);
     },
-    legancy: function(target, constructor, exception) {
-      target.stack = (new exception()).stack;
+    fixLegancyStackTrace: function(stack, stringified) {
+      var st = stack;
+      if (typeof(stack) !== 'string') {
+        // On IE the stack field is empty so setting to toString() :-/
+        st = stringified;
+      }
+      // Hands down, if all fails, just replace Error with nice Eid string
+      if (st.indexOf(stringified) < 0) {
+        st = st.replace(/^(?:Error\n)?/, stringified + "\n").trim();
+      }
+      return st;
+    },
+    legancy: function(target, constructor, exceptionConstructor) {
+      // Hacks for IE an Edge
+      var stringified = target.toString();
+      // try to fetch stacktrace from JS standard Error
+      var st = (new exceptionConstructor()).stack;
+      target.stack = CorrectStackTrace.fixLegancyStackTrace(st, stringified);
     }
   };
+  CorrectStackTrace.fixLegancyStackTrace('Error\n');
   CorrectStackTrace.legancy({}, null, Object);
 
   var correctStackTrace = function(target, constructor) {
@@ -73,13 +90,14 @@
     var tmp = Error.apply(this, [message]);
     tmp.name = this.name = 'EidRuntimeException';
     this.message = tmp.message;
+    this.eid = eid;
     correctStackTrace(this, EidRuntimeException);
 
     return this;
   }
-  var IntermediateInheritor = function() {};
-  IntermediateInheritor.prototype = Error.prototype;
-  EidRuntimeException.prototype = new IntermediateInheritor();
+  EidRuntimeException.prototype = Object.create(Error.prototype, {
+    constructor: { value: EidRuntimeException }
+  });
 
   /**
    * <strong>This class shouldn't be used in any public API or library.</strong> It is designed to be used for in-house development