[soft navs] Fix failing CHECK in ProcessCustomWeakness

Michal Mocny · chromium-wpt-export-bot · commit 794fb3628472 · 2025-05-30T14:27:11.000-07:00
We expect that as long as we have one of two specific Member<SoftNavigationContext> references non nullptr, then we shouldn't ever have an empty list of potential soft navigations. However, we were previously accidentally setting the most_recent_ context to a context that comes from another window, which meant we could have a case where all interactions are GC-ed and yet one of these values was not null. Change to guard against this in the one place it could happen, but, also change the CHECK to NotFatalUntil since these are really not important to enforce, they are just extra cautious. Bug: 421199934, 40871933 Change-Id: I6d120389a032ec6ae51d660299170d8f85aab642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6604294 Commit-Queue: Michal Mocny <mmocny@chromium.org> Reviewed-by: Scott Haseley <shaseley@chromium.org> Reviewed-by: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1467654}
diff --git a/soft-navigation-heuristics/smoke/tentative/resources/other_window.html b/soft-navigation-heuristics/smoke/tentative/resources/other_window.html
@@ -0,0 +1,19 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+
+<h1>This is some text</h1>
+
+<script>
+  function navigate() {
+    history.pushState({}, "", "/different-url");
+  }
+
+  async function getNextSoftNavEntry() {
+    return new Promise(resolve => {
+      new PerformanceObserver((list, observer) => {
+        observer.disconnect();
+        resolve(list.getEntries()[0]);
+      }).observe({ type: "soft-navigation" });
+    });
+  }
+</script>
diff --git a/soft-navigation-heuristics/smoke/tentative/window-open-cross-scheduling.html b/soft-navigation-heuristics/smoke/tentative/window-open-cross-scheduling.html
@@ -0,0 +1,45 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <title>Scheduling soft navigations across windows.</title>
+    <script src="/resources/testharness.js"></script>
+    <script src="/resources/testharnessreport.js"></script>
+    <script src="/resources/testdriver.js"></script>
+    <script src="/resources/testdriver-vendor.js"></script>
+    <script></script>
+  </head>
+  <body>
+    <button id="button" onclick="navigateChild()">Press Me!</button>
+
+    <script>
+      const child = window.open('resources/other_window.html');
+      const childLoaded = new Promise(resolve => child.onload = resolve);
+
+      function navigateChild() {
+        // `child.navigate()` is a function declared in the `other_window.html`.
+        child.navigate();
+      }
+
+      promise_test(async (t) => {
+        await childLoaded;
+
+        if (test_driver) {
+          test_driver.click(document.getElementById("button"));
+        }
+
+        new PerformanceObserver((list, observer) => t.step(() => {
+          observer.disconnect();
+          assert_unreached("Parent window should not detect a soft-navigation.");
+        })).observe({ type: "soft-navigation" });
+
+        child.getNextSoftNavEntry().then((entry) => {
+          assert_unreached("Child window should not detect a soft-navigation.");
+        });
+
+        await new Promise(resolve => t.step_timeout(resolve, 2000));
+
+      }, "Opening a new window and updating a URL in it shouldn't crash");
+    </script>
+  </body>
+</html>
