Skip to content

Commit 8c45076

Browse files
committed
More cleanup
1 parent a448a36 commit 8c45076

File tree

6 files changed

+3
-71
lines changed

6 files changed

+3
-71
lines changed

core/src/main/java/org/dynmapblockscan/core/AbstractBlockScanBase.java

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@
4242
import org.dynmapblockscan.core.model.BlockElement;
4343
import org.dynmapblockscan.core.model.BlockFace;
4444
import org.dynmapblockscan.core.model.BlockModel;
45-
import org.dynmapblockscan.core.statehandlers.IStateHandler;
46-
import org.dynmapblockscan.core.statehandlers.IStateHandlerFactory;
47-
import org.dynmapblockscan.core.statehandlers.SimpleMetadataStateHandler;
4845
import org.dynmapblockscan.core.statehandlers.StateContainer;
4946
import org.dynmapblockscan.core.statehandlers.StateContainer.StateRec;
5047
import org.dynmapblockscan.core.statehandlers.StateContainer.WellKnownBlockClasses;
@@ -65,15 +62,10 @@ public abstract class AbstractBlockScanBase {
6562

6663
//private Gson gson = new GsonBuilder().setPrettyPrinting().create();
6764

68-
protected IStateHandlerFactory[] state_handler = {
69-
new SimpleMetadataStateHandler(false)
70-
};
71-
7265
public static class BlockRecord {
7366
public StateContainer sc;
7467
public Map<StateRec, List<VariantList>> varList; // Model references for block
7568
public Set<String> renderProps; // Set of render properties
76-
public IStateHandler handler; // Best handler
7769
}
7870

7971
protected static class PathElement {
@@ -832,15 +824,11 @@ protected void resolveAllElements(Map<String, BlockRecord> blockRecords, Map<Str
832824
}
833825
// If single simple full cube
834826
if ((elems.size() == 1) && (elems.get(0).isSimpleBlock())) {
835-
if (br.handler != null) {
836-
//logger.info(String.format("%s: %s is simple block with %s map", blkname, var.getKey(), br.handler.getName()));
837-
registerSimpleDynmapCubes(blkname, var.getKey(), elems.get(0), br.sc.getBlockType());
838-
}
827+
//logger.info(String.format("%s: %s is simple block with %s map", blkname, var.getKey(), br.handler.getName()));
828+
registerSimpleDynmapCubes(blkname, var.getKey(), elems.get(0), br.sc.getBlockType());
839829
}
840830
else {
841-
if (br.handler != null) {
842-
registerModelListModel(blkname, var.getKey(), elems, br.sc.getBlockType());
843-
}
831+
registerModelListModel(blkname, var.getKey(), elems, br.sc.getBlockType());
844832
}
845833
}
846834
}

forge-1.14.4/src/main/java/org/dynmapblockscan/forge_1_14_4/DynmapBlockScanPlugin.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,17 +158,6 @@ else if (uses_nonmodel) {
158158
else {
159159
br.varList = Collections.emptyMap();
160160
}
161-
// Check for matching handler
162-
br.handler = null;
163-
for (IStateHandlerFactory f : state_handler) {
164-
br.handler = f.canHandleBlockState(br.sc);
165-
if (br.handler != null) {
166-
break;
167-
}
168-
}
169-
if (br.handler == null) {
170-
logger.info(rl + ": NO MATCHING HANDLER");
171-
}
172161
blockRecords.put(rl.toString(), br);
173162
}
174163

forge-1.15.2/src/main/java/org/dynmapblockscan/forge_1_15_2/DynmapBlockScanPlugin.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -158,17 +158,6 @@ else if (uses_nonmodel) {
158158
else {
159159
br.varList = Collections.emptyMap();
160160
}
161-
// Check for matching handler
162-
br.handler = null;
163-
for (IStateHandlerFactory f : state_handler) {
164-
br.handler = f.canHandleBlockState(br.sc);
165-
if (br.handler != null) {
166-
break;
167-
}
168-
}
169-
if (br.handler == null) {
170-
logger.info(rl + ": NO MATCHING HANDLER");
171-
}
172161
blockRecords.put(rl.toString(), br);
173162
}
174163

forge-1.16.5/src/main/java/org/dynmapblockscan/forge_1_16_5/DynmapBlockScanPlugin.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -162,17 +162,6 @@ else if (uses_nonmodel) {
162162
else {
163163
br.varList = Collections.emptyMap();
164164
}
165-
// Check for matching handler
166-
br.handler = null;
167-
for (IStateHandlerFactory f : state_handler) {
168-
br.handler = f.canHandleBlockState(br.sc);
169-
if (br.handler != null) {
170-
break;
171-
}
172-
}
173-
if (br.handler == null) {
174-
logger.info(rl + ": NO MATCHING HANDLER");
175-
}
176165
blockRecords.put(rl.toString(), br);
177166
}
178167

forge-1.17.1/src/main/java/org/dynmapblockscan/forge_1_17_1/DynmapBlockScanPlugin.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -164,17 +164,6 @@ else if (uses_nonmodel) {
164164
else {
165165
br.varList = Collections.emptyMap();
166166
}
167-
// Check for matching handler
168-
br.handler = null;
169-
for (IStateHandlerFactory f : state_handler) {
170-
br.handler = f.canHandleBlockState(br.sc);
171-
if (br.handler != null) {
172-
break;
173-
}
174-
}
175-
if (br.handler == null) {
176-
logger.info(rl + ": NO MATCHING HANDLER");
177-
}
178167
blockRecords.put(rl.toString(), br);
179168
}
180169

forge-1.18/src/main/java/org/dynmapblockscan/forge_1_18/DynmapBlockScanPlugin.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package org.dynmapblockscan.forge_1_18;
22

3-
43
import java.io.File;
54
import java.io.InputStream;
65
import java.util.ArrayList;
@@ -20,7 +19,6 @@
2019
import org.dynmapblockscan.core.blockstate.BSBlockState;
2120
import org.dynmapblockscan.core.blockstate.VariantList;
2221
import org.dynmapblockscan.core.model.BlockModel;
23-
import org.dynmapblockscan.core.statehandlers.IStateHandlerFactory;
2422
import org.dynmapblockscan.core.statehandlers.StateContainer.StateRec;
2523
import org.dynmapblockscan.forge_1_18.statehandlers.ForgeStateContainer;
2624

@@ -164,16 +162,6 @@ else if (uses_nonmodel) {
164162
br.varList = Collections.emptyMap();
165163
}
166164
// Check for matching handler
167-
br.handler = null;
168-
for (IStateHandlerFactory f : state_handler) {
169-
br.handler = f.canHandleBlockState(br.sc);
170-
if (br.handler != null) {
171-
break;
172-
}
173-
}
174-
if (br.handler == null) {
175-
logger.info(rl + ": NO MATCHING HANDLER");
176-
}
177165
blockRecords.put(rl.toString(), br);
178166
}
179167

0 commit comments

Comments
 (0)