Use npm workspaces #2476
Merged
Use npm workspaces #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this has broken things horribly, brb... |
lockfilemageddon updated cheerio from rc.10 to final. This included a breaking change which enzyme hasn't been updated to handle, but seeing as enzyme is no longer maintained....let's just throw our toys out the pram and switch to testing library
|
I tell a lie, deleted node_modules and reinstalled and it was fine. Still...thanks npm |
|
Can you catch up to main so we don't have there merge conflicts? |
|
@Westbrook done! |
Westbrook
approved these changes
Aug 6, 2025
| @@ -13,17 +13,45 @@ export namespace Components { | |||
| } | |||
| interface ComponentWithDeclarativeEvent { | |||
| "camelHandled": boolean; | |||
| /** | |||
There was a problem hiding this comment.
Oh good, I was seeing this popup in a couple of places, now it will be quite again. 🙇🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install time for this repository is getting increasingly long as it runs installs separately in each library.
Switching to using npm workspaces makes a substantial reduction to this.
The churn in lock file is unfortunate, but I think unavoidable.