fix: missing dependencies (#119)

Author: alexander-akait

.github/workflows/nodejs.yml

@@ -81,7 +81,7 @@ jobs:
         run: npm i -g npm
 
       - name: Install dependencies
-        run: npm ci
+        run: npm ci --force
 
       - name: Install webpack ${{ matrix.webpack-version }}
         run: npm i webpack@${{ matrix.webpack-version }}

package-lock.json

@@ -31,8 +31,7 @@
     "pretest": "npm run lint",
     "test": "npm run test:coverage",
     "prepare": "npm run build",
-    "release": "standard-version",
-    "defaults": "webpack-defaults"
+    "release": "standard-version"
   },
   "files": [
     "dist"
@@ -53,7 +52,6 @@
     "@babel/preset-env": "^7.12.1",
     "@commitlint/cli": "^11.0.0",
     "@commitlint/config-conventional": "^11.0.0",
-    "@webpack-contrib/defaults": "^6.3.0",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "babel-jest": "^26.6.1",
     "babel-loader": "^8.1.0",
@@ -69,16 +67,17 @@
     "lint-staged": "^10.5.0",
     "lodash": "^4.17.20",
     "memfs": "^3.2.0",
-    "mini-css-extract-plugin": "^1.2.1",
+    "mini-css-extract-plugin": "^1.6.0",
     "nodemon": "^2.0.6",
     "npm-run-all": "^4.1.5",
+    "postcss": "^8.2.14",
+    "postcss-font-magician": "^3.0.0",
+    "postcss-loader": "^5.2.0",
     "prettier": "^2.1.2",
     "sass": "^1.27.0",
     "sass-loader": "^11.0.1",
     "standard-version": "^9.0.0",
-    "webpack": "^5.3.0",
-    "webpack-cli": "^4.1.0",
-    "webpack-defaults": "^4.0.0"
+    "webpack": "^5.3.0"
   },
   "keywords": [
     "webpack"

package.json

@@ -36,9 +36,15 @@ function pitch() {
     },
     (err, r) => {
       if (r) {
-        r.buildDependencies.forEach((d) => this.addBuildDependency(d));
         r.fileDependencies.forEach((d) => this.addDependency(d));
         r.contextDependencies.forEach((d) => this.addContextDependency(d));
+        r.missingDependencies.forEach((d) => this.addMissingDependency(d));
+        r.buildDependencies.forEach((d) =>
+          // Compatibility with webpack v4
+          this.addBuildDependency
+            ? this.addBuildDependency(d)
+            : this.addDependency(d)
+        );
       }
 
       if (err) {

src/index.js

@@ -119,7 +119,9 @@ const queue = asyncQueue(({ id, data }, taskCallback) => {
       });
       nextQuestionId += 1;
     };
+
     const buildDependencies = [];
+
     loaderRunner.runLoaders(
       {
         loaders: data.loaders,
@@ -252,6 +254,7 @@ const queue = asyncQueue(({ id, data }, taskCallback) => {
           cacheable,
           fileDependencies,
           contextDependencies,
+          missingDependencies,
         } = lrResult;
         const buffersToSend = [];
         const convertedResult =
@@ -283,9 +286,10 @@ const queue = asyncQueue(({ id, data }, taskCallback) => {
           result: {
             result: convertedResult,
             cacheable,
-            buildDependencies,
             fileDependencies,
             contextDependencies,
+            missingDependencies,
+            buildDependencies,
           },
           data: buffersToSend.map((buffer) => buffer.length),
         });

src/worker.js

@@ -16,6 +16,7 @@ const runGetPoolMock = (error) => {
       run: jest.fn((opts, cb) => {
         cb(error, {
           buildDependencies: [],
+          missingDependencies: [],
           fileDependencies: [],
           contextDependencies: [],
           result: {},

test/pitch.test.js

@@ -0,0 +1,3 @@
+module.exports = {
+  plugins: ['postcss-font-magician'],
+};

test/sass-loader-example/package-lock.json

@@ -22,7 +22,11 @@ module.exports = (env) => {
   };
   if (+env.threads > 0) {
     threadLoader.warmup(workerPool, ['babel-loader', 'babel-preset-env']);
-    threadLoader.warmup(workerPoolSass, ['sass-loader', 'css-loader']);
+    threadLoader.warmup(workerPoolSass, [
+      'sass-loader',
+      'postcss-loader',
+      'css-loader',
+    ]);
   }
   return {
     mode: 'none',
@@ -53,6 +57,14 @@ module.exports = (env) => {
               options: workerPoolSass,
             },
             'css-loader',
+            {
+              loader: 'postcss-loader',
+              options: {
+                postcssOptions: {
+                  config: path.resolve(__dirname, './postcss.config.js'),
+                },
+              },
+            },
             { loader: 'sass-loader', options: sassLoaderOptions },
           ].filter(Boolean),
         },